Fixup and refactor root_env_config resolution #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8a07c58.
This reverts commit 65e7f08.
…e-to-support-fractional-time
…e-to-support-fractional-time
for more information, see https://pre-commit.ci
…e-to-support-fractional-time
This reverts commit 45ad11f.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…-env-resolution-from-different-dirs-and-restores
for more information, see https://pre-commit.ci
…-env-resolution-from-different-dirs-and-restores
…-env-resolution-from-different-dirs-and-restores
bpkroth
commented
Jun 24, 2025
bpkroth
commented
Jun 24, 2025
|
|
||
|
|
||
| def get_git_info(path: str = __file__) -> tuple[str, str, str]: | ||
| def get_git_root(path: str = __file__) -> str: |
There was a problem hiding this comment.
The git changes should be merged in #991 first to make it easier to review this PR.
…-env-resolution-from-different-dirs-and-restores
…-env-resolution-from-different-dirs-and-restores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Title
Fixup refactor/allow git repo root env resolution from different dirs and restores
Description
mlos_bench/mlos_bench/testsdirectory in which the root env config is initially resolved from the root of the repo and storage interally asmlos_bench/mlos_bench/tests/environment.jsoncand next re-used by another component (e.g.,Scheduler) as that new path which doesn't exist when run from themlos_bench/mlos_bench/testsdir.This part is mostly cosmetic, since currently those values aren't used by TrialRunners or Environments, but is good to fix for potential future works.
Type of Change
Testing
Additional Notes (optional)
This is part of a series of fixups and should be merged after #991