Skip to content

Add upgradeCallback handler for upgrade telemetry tracking #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

amshankamsft
Copy link
Contributor

Add upgradeCallback handler for upgrade telemetry tracking

@amshankamsft
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

eliranek1
eliranek1 previously approved these changes Mar 26, 2025
Copy link
Collaborator

@balaji-viswanathan balaji-viswanathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@thomastay thomastay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm but i think we should change from date.now to performance.now

@amshankamsft amshankamsft marked this pull request as ready for review April 1, 2025 19:01
thomastay
thomastay previously approved these changes Apr 1, 2025
Copy link
Contributor

@thomastay thomastay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@thomastay thomastay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good left some comments

Copy link
Contributor

@thomastay thomastay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new tests lgtm

@thomastay thomastay merged commit 7653670 into microsoft:master Apr 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants