-
Notifications
You must be signed in to change notification settings - Fork 80
Optimize pqap.sh script #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Combine the `pqap_stop` and `pqap_start` functions into a single `pqap_restart` function and optimize interface checking. * Replace `ensure_interface_up` and `is_interface_up` functions with a single `check_and_ensure_interface_up` function. * Update `pqap_start` function to use `check_and_ensure_interface_up` instead of `is_interface_up` and `ensure_interface_up`. * Move `check_deps` function to a more appropriate location in the script. * Update main function to call `pqap_restart` instead of `pqap_start`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/pqcrypto-vpn?shareId=XXXX-XXXX-XXXX-XXXX).
|
@Kohart please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Kohart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check done!
Combine the
pqap_stopandpqap_startfunctions into a singlepqap_restartfunction and optimize interface checking.ensure_interface_upandis_interface_upfunctions with a singlecheck_and_ensure_interface_upfunction.pqap_startfunction to usecheck_and_ensure_interface_upinstead ofis_interface_upandensure_interface_up.check_depsfunction to a more appropriate location in the script.pqap_restartinstead ofpqap_start.For more details, open the Copilot Workspace session.