Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Add keyboard handling for XArray HTML view #474

Merged
merged 12 commits into from
Aug 27, 2024

Conversation

srijan55
Copy link
Contributor

The default html view generated via XArray uses hidden checkboxes to achieve collapse expand behaviour.
This PR -

  • Makes the hidden checkboxes visible with 0 opacity , to make them accessible via keyboard
  • Make style changes to associated labels for focus, to highlight where the keyboard focus is
  • Change the grid layout to account for the invisible checkboxes
Meeting.with.Manish.Kumar.Gupta-20240821_192932-Meeting.Recording.mp4

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-meadow-0fc35e30f-474.eastus2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-stone-06c70c70f-474.eastus2.azurestaticapps.net

@ghidalgo3
Copy link
Contributor

The Cypress test failure is the same one I was getting with Sentinel-1 removal, but then disabling that test caused other things to fail in #473. Maybe it was something else I changed? Anyway you'll need to disable the one cypress test.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-meadow-0fc35e30f-474.eastus2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-stone-06c70c70f-474.eastus2.azurestaticapps.net

@ghidalgo3 ghidalgo3 merged commit 5d67e4c into develop Aug 27, 2024
9 checks passed
@ghidalgo3 ghidalgo3 deleted the user/manishkg/xArrayAccess branch August 27, 2024 19:14
@ghidalgo3
Copy link
Contributor

Thanks, ping me if you have any issues going through the release flow to deploy this to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants