Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summarize extra comments #2779

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Summarize extra comments #2779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/libraries/Microsoft.PowerFx.Interpreter/Functions/LibraryTable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
using System.Collections.Generic;
using System.Globalization;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.PowerFx.Core.Entities;
using Microsoft.PowerFx.Core.Functions;
Expand Down Expand Up @@ -1404,6 +1403,11 @@ public static FormulaValue PatchRecord(IRContext irContext, FormulaValue[] args)

public static async ValueTask<FormulaValue> Summarize(EvalVisitor runner, EvalVisitorContext context, IRContext irContext, FormulaValue[] args)
{
// This function expects 3 types of arguments:
// 1. TableValue (arg0)
// 2. StringValue (columns to group by) at any position > 0.
// 3. LambdasFormulaValue (aggregates) at any position > 0. Represented by a record value eg {TotalAmount:Sum(Amount)}

if (args[0] is BlankValue)
{
return new BlankValue(irContext);
Expand All @@ -1419,6 +1423,7 @@ public static async ValueTask<FormulaValue> Summarize(EvalVisitor runner, EvalVi
return CommonErrors.RuntimeTypeMismatch(irContext);
}

// Building a dictionary of key records (based on groupping columns) and a subset of records that match the key.
var keyRecords = new Dictionary<string, RecordValue>();
var groupByRecords = new Dictionary<string, List<RecordValue>>();

Expand All @@ -1442,6 +1447,7 @@ public static async ValueTask<FormulaValue> Summarize(EvalVisitor runner, EvalVi
var showColumnsArgs = new List<FormulaValue>() { row.Value };
showColumnsArgs.AddRange(stringArgs);

// We call ShowColumns to keep only the columns that are part of the group by.
var keyRecord = await ShowColumns(runner, context, IRContext.NotInSource(FormulaType.Build(irContext.ResultType._type.ToRecord())), showColumnsArgs.ToArray()).ConfigureAwait(false);
var key = keyRecord.ToExpression();
anderson-joyle marked this conversation as resolved.
Show resolved Hide resolved

Expand All @@ -1456,20 +1462,21 @@ public static async ValueTask<FormulaValue> Summarize(EvalVisitor runner, EvalVi

var finalRecords = new List<DValue<RecordValue>>();

foreach (var group in groupByRecords)
// Evaluate all aggregates for each group and include the result as columns name and column value in the final record.
foreach (var thisGroup in groupByRecords)
{
runner.CancellationToken.ThrowIfCancellationRequested();

var newTable = FormulaValue.NewTable((RecordType)FormulaType.Build(tableValue.Type._type.ToRecord()), group.Value);
var record = (InMemoryRecordValue)keyRecords[group.Key];
var thisGroupTableValue = FormulaValue.NewTable(tableValue.Type.ToRecord(), thisGroup.Value);
var record = (InMemoryRecordValue)keyRecords[thisGroup.Key];
var fields = new Dictionary<string, FormulaValue>();

foreach (var field in record.Fields)
{
fields.Add(field.Name, field.Value);
}

SymbolContext childContext = context.SymbolContext.WithScopeValues(newTable);
SymbolContext childContext = context.SymbolContext.WithScopeValues(thisGroupTableValue);

foreach (LambdaFormulaValue arg in args.Where(arg => arg is LambdaFormulaValue))
{
Expand Down
Loading