Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] System.IO.Abstractions update #21061

Merged
merged 2 commits into from
Oct 16, 2022
Merged

[Chore] System.IO.Abstractions update #21061

merged 2 commits into from
Oct 16, 2022

Conversation

davidegiacometti
Copy link
Collaborator

Summary of the Pull Request

PowerToy is using an old version of System.IO.Abstractions
Let's do this early on the new release cycle 😃

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  • Build
  • Validate that the following apps are working:
    • Settings
    • ColorPicker
    • ImageResizer,
    • Fancy Zones Editor,
    • Launcher folder plugin
    • PreviewPane: GCode, Markdown, Monaco, PDF

@davidegiacometti
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidegiacometti davidegiacometti mentioned this pull request Oct 9, 2022
Closed
@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Oct 12, 2022
@davidegiacometti davidegiacometti force-pushed the users/davidegiacometti/system-io-abstractions branch from bc89c65 to c8cc15a Compare October 13, 2022 21:18
jaimecbernardo
jaimecbernardo approved these changes Oct 16, 2022
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@jaimecbernardo jaimecbernardo merged commit 887da6d into main Oct 16, 2022
@davidegiacometti davidegiacometti deleted the users/davidegiacometti/system-io-abstractions branch October 16, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

Assignees
No one assigned
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidegiacometti @jaimecbernardo @crutkas