Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic loading examples #420

Merged
merged 6 commits into from
Sep 26, 2024
Merged

Dynamic loading examples #420

merged 6 commits into from
Sep 26, 2024

Conversation

liqul
Copy link
Contributor

@liqul liqul commented Sep 24, 2024

  1. support dynamically loading examples for different roles
  2. move loading example to role base class
  3. rename codeinterpreter_examples to code_generator_examples in project folder; need manual migration

Copy link
Member

@Jack-Q Jack-Q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems most of changes are the same as experiences loading, maybe it would work in the same way. Not sure whether would need to have a common class to abstract these shared loading logics together in the future.

taskweaver/role/role.py Outdated Show resolved Hide resolved
@liqul
Copy link
Contributor Author

liqul commented Sep 26, 2024

Seems most of changes are the same as experiences loading, maybe it would work in the same way. Not sure whether would need to have a common class to abstract these shared loading logics together in the future.

Exactly, that is why I left a todo item in the comments. They all belong to a category that should be dynamically loaded in runtime. A third could be the plugins. But I'm not sure how to abstract at this moment.

@liqul liqul merged commit 2d8086d into main Sep 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants