Skip to content

fix calculateColor function #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix calculateColor function #1121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions 5-browser-extension/3-background-tasks-and-performance/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,11 @@ function calculateColor(value) {
let co2Scale = [0, 150, 600, 750, 800];
let colors = ['#2AA364', '#F5EB4D', '#9E4229', '#381D02', '#381D02'];

let closestNum = co2Scale.sort((a, b) => {
let closestNum = co2Scale.slice().sort((a, b) => {
return Math.abs(a - value) - Math.abs(b - value);
})[0];
Comment on lines +68 to 70
Copy link

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sorting logic finds the value with minimum absolute difference from the input value, but this doesn't guarantee it will be found in the original co2Scale array. If the input value is between two scale values, the closest might not exist in the original array, causing findIndex to return -1.

Copilot uses AI. Check for mistakes.
console.log(value + ' is closest to ' + closestNum);
let num = (element) => element > closestNum;
let num = (element) => element === closestNum;
let scaleIndex = co2Scale.findIndex(num);

let closestColor = colors[scaleIndex];
Expand Down