Skip to content

Included more robust client side validation #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Included more robust client side validation #1513

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
396850d
Included more rebust client side validation
Roshan-Metrix Sep 21, 2025
f920e8c
Update 7-bank-project/solution/app.js
Roshan-Metrix Oct 3, 2025
2195fcd
Merge branch 'main' into Included_more_robust_client_side_validation
Roshan-Metrix Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions 7-bank-project/solution/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ function getAccounts() {
}

function saveAccounts(accounts) {
localStorage.setItem(accountsKey, JSON.stringify(accounts));
  localStorage.setItem(accountsKey, JSON.stringify(accounts));
}

function migrateSchema() {
Expand All @@ -88,8 +88,8 @@ function migrateSchema() {
}

function findAccount(user) {
const accounts = getAccounts();
return accounts.find(acc => acc.user === user) || null;
  const accounts = getAccounts();
  return accounts.find(acc => acc.user === user) || null;
}

async function getAccount(user) {
Expand Down Expand Up @@ -171,7 +171,7 @@ async function createTransaction(user, transactionJson) {

// Keep a frozen state object to avoid accidental mutations
let state = Object.freeze({
account: null
  account: null
});

function updateState(property, newData) {
Expand Down Expand Up @@ -263,8 +263,8 @@ async function login() {
const data = await getAccount(user);
if (data.error) return updateElement('loginError', data.error);

updateState('account', data);
navigate('/dashboard');
  updateState('account', data);
  navigate('/dashboard');
}

async function register() {
Expand All @@ -283,8 +283,17 @@ async function register() {

if (result.error) return updateElement('registerError', result.error);

updateState('account', result);
navigate('/dashboard');
  const formData = new FormData(registerForm);
  const data = Object.fromEntries(formData);
  const jsonData = JSON.stringify(data);
  const result = await createAccount(jsonData);

  if (result.error) {
    return updateElement('registerError', result.error);
  }

  updateState('account', result);
  navigate('/dashboard');
}

function attachAuthHandlers() {
Expand All @@ -309,12 +318,12 @@ async function updateAccountData() {
const data = await getAccount(account.user);
if (data.error) return logout();

updateState('account', data);
  updateState('account', data);
}

async function refresh() {
await updateAccountData();
updateDashboard();
  await updateAccountData();
  updateDashboard();
}

function updateDashboard() {
Expand Down Expand Up @@ -449,8 +458,8 @@ function cancelTransaction() {
}

function logout() {
updateState('account', null);
navigate('/login');
  updateState('account', null);
  navigate('/login');
}

// ---------------------------------------------------------------------------
Expand Down