Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Hack] 063-Intro To Azure Red Hat OpenShift WhatTheHack #640

Merged
merged 79 commits into from
Nov 2, 2023

Conversation

danielkon96
Copy link
Contributor

No description provided.

@danielkon96 danielkon96 requested a review from a team as a code owner June 6, 2023 18:21
@jrzyshr jrzyshr changed the title Intro To Azure Red Hat OpenShift WhatTheHack [New Hack] 063-Intro To Azure Red Hat OpenShift WhatTheHack Jun 13, 2023
Fixed typos
Changed to "authentication method"
fixed typo
Copy link
Contributor

@perktime perktime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good!

@danielkon96
Copy link
Contributor Author

danielkon96 commented Jul 19, 2023

Content looks good!

One thing I just noticed is that Sowmyan's name is spelled wrong in the readme. I will make that change.

@danielkon96
Copy link
Contributor Author

@perktime @jrzyshr Is this ready to merge? It needs approval from 1 more person.

Fixed spacing/capitalization in the title. Added GitHub links for the authors, and removed the link to the lecture presentations.  That belongs ONLY in the coach guide.
Fixed spacing in hack title.
Updated C8 to refer to Entra ID instead of Azure AD
Cleaned up Azure Requirements section
Replaced AAD with Entra ID
Copy link
Collaborator

@jrzyshr jrzyshr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks team for this awesome new contribution to the WTH collection!

@jrzyshr jrzyshr merged commit 3bf881c into microsoft:master Nov 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants