Draft: Merge develop changes (April 2024)

.github/CODEOWNERS

@@ -6,3 +6,112 @@
 
 # Root files
 /* @microsoft/driver-samples-maintainers
+
+# Windows Implementation Library submodule
+/wil/ @microsoft/driver-samples-maintainers
+
+# Audio
+/audio/ @microsoft/windowsaudio
+
+# Bluetooth
+/bluetooth/ @microsoft/bluetooth
+
+# Camera Platform
+/avstream/ @microsoft/cameraplatdev
+/general/SimpleMediaSource/ @microsoft/cameraplatdev
+
+# Cellular Core
+/network/wwan/ @microsoft/cellcore
+/nfc/ @microsoft/cellcore
+
+# Connection Awareness
+/gnss/ @microsoft/connection-awareness
+/network/radio/ @microsoft/connection-awareness
+
+# Core Networking
+/network/wsk/ @microsoft/corenetworking
+
+# Consumer Storage
+/sd/ @microsoft/consumer-storage
+/smartcrd/ @microsoft/consumer-storage
+
+# Device Enumeration and Interconnect
+/gpio/ @microsoft/device-enumeration-and-interconnect
+/pofx/PEP/ @microsoft/device-enumeration-and-interconnect
+/prm/ @microsoft/device-enumeration-and-interconnect
+/wmi/wmiacpi/ @microsoft/device-enumeration-and-interconnect
+/general/SystemDma/ @microsoft/device-enumeration-and-interconnect
+
+# Display Kernel
+/video/ @microsoft/display-kernel-devs
+
+# Driver Development Supplemental Tools
+/tools/ @microsoft/windows-driver-developers-supplemental-tools-admins
+
+# Energy Efficiency
+/pofx/WDF/ @microsoft/ee-devs
+/powerlimit/ @microsoft/ee-devs
+/simbatt/ @microsoft/ee-devs
+/thermal/ @microsoft/ee-devs
+
+# Event Tracing for Windows
+/general/perfcounters/ @microsoft/etw
+/general/tracing/ @microsoft/etw
+
+# File Systems
+/filesys/cdfs/ @microsoft/filesystems
+/filesys/fastfat/ @microsoft/filesystems
+
+# Filter Manager
+/filesys/miniFilter/ @microsoft/filter-manager
+
+# Kernel Core
+/general/cancel/ @microsoft/kernel-core
+/general/event/ @microsoft/kernel-core
+/general/registry/ @microsoft/kernel-core
+
+# Network Driver Platform
+/network/config/ @microsoft/network-driver-platform
+/network/modem/ @microsoft/network-driver-platform
+/network/ndis/ @microsoft/network-driver-platform
+
+# Network Security
+/network/trans/ @microsoft/netsec
+
+# Platform Integrity
+/security/ @microsoft/platform-integrity
+/TrEE/ @microsoft/platform-integrity
+
+# PnP
+/general/DCHU/ @microsoft/pnp
+/setup/ @microsoft/pnp
+
+# Print
+/print/ @microsoft/core-print
+/wia/ @microsoft/core-print
+
+# Sensors Platform
+/sensors/ @microsoft/sensors-platform
+
+# Storage
+/storage/ @microsoft/storage-core
+
+# Windows Driver Framework (WDF) samples
+/general/echo/ @microsoft/coreos-buses-and-wdf
+/general/ioctl/ @microsoft/coreos-buses-and-wdf
+/general/pcidrv/ @microsoft/coreos-buses-and-wdf
+/general/PLX9x5x/ @microsoft/coreos-buses-and-wdf
+/general/toaster/ @microsoft/coreos-buses-and-wdf
+/hid/ @microsoft/coreos-buses-and-wdf
+/input/ @microsoft/coreos-buses-and-wdf
+/pofx/UMDF2/ @microsoft/coreos-buses-and-wdf
+/serial/ @microsoft/coreos-buses-and-wdf
+/spb/ @microsoft/coreos-buses-and-wdf
+/usb/ @microsoft/coreos-buses-and-wdf
+/wmi/wmisamp/ @microsoft/coreos-buses-and-wdf
+
+# Windows Internet of Things
+/pos/ @microsoft/winiotdev
+
+# Wi-Fi Core
+/network/wlan/ @microsoft/wi-fi-core

.github/workflows/Code-Scanning.yml

@@ -33,17 +33,17 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         submodules: 'recursive'
 
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v3
       with:
         languages: ${{ matrix.language }}
-
+        packs: microsoft/windows-drivers
     - name: Add MSBuild to PATH
-      uses: microsoft/setup-msbuild@v1.3.1
+      uses: microsoft/setup-msbuild@v2
 
     - name: Retrieve and build all available solutions
       run: |
@@ -57,3 +57,6 @@ jobs:
       uses: github/codeql-action/analyze@v3
       with:
         category: "/language:${{matrix.language}}"
+
+
+

.github/workflows/ci-pr.yml

@@ -18,12 +18,12 @@ jobs:
     runs-on: windows-2022
     steps:
       - name: Check out repository code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           submodules: 'recursive'
 
       - name: Add MSBuild to PATH
-        uses: microsoft/setup-msbuild@v1.3.1
+        uses: microsoft/setup-msbuild@v2
 
       - name: Get changed files
         id: get-changed-files
@@ -54,7 +54,7 @@ jobs:
     if: always()
     steps:
       - name: Check out repository code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Retrieve overview reports
         uses: actions/download-artifact@v3

.github/workflows/ci.yml

@@ -18,12 +18,12 @@ jobs:
     runs-on: windows-2022
     steps:
       - name: Check out repository code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           submodules: 'recursive'
 
       - name: Add MSBuild to PATH
-        uses: microsoft/setup-msbuild@v1.3.1
+        uses: microsoft/setup-msbuild@v2
 
       - name: Retrieve and build all available solutions
         run: |
@@ -47,7 +47,7 @@ jobs:
     if: always()
     steps:
       - name: Check out repository code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Retrieve overview reports
         uses: actions/download-artifact@v3

Build-Sample.ps1

@@ -152,7 +152,7 @@ for ($i=0; $i -le 2; $i++) {
     $warnLogFilePath = "$LogFilesDirectory\$SampleName.$Configuration.$Platform.$i.wrn"
     $OutLogFilePath = "$LogFilesDirectory\$SampleName.$Configuration.$Platform.$i.out"
 
-    msbuild $solutionFile -clp:Verbosity=m -t:rebuild -property:Configuration=$Configuration -property:Platform=$Platform -p:TargetVersion=Windows10 -p:InfVerif_AdditionalOptions="$InfVerif_AdditionalOptions" -p:SignToolWS=/fdws -p:DriverCFlagAddOn=/wd4996 -warnaserror -flp1:errorsonly`;logfile=$errorLogFilePath -flp2:WarningsOnly`;logfile=$warnLogFilePath -noLogo > $OutLogFilePath
+    msbuild $solutionFile -clp:Verbosity=m -t:rebuild -property:Configuration=$Configuration -property:Platform=$Platform -p:TargetVersion=Windows10 -p:InfVerif_AdditionalOptions="$InfVerif_AdditionalOptions" -warnaserror -flp1:errorsonly`;logfile=$errorLogFilePath -flp2:WarningsOnly`;logfile=$warnLogFilePath -noLogo > $OutLogFilePath
     if ($env:WDS_WipeOutputs -ne $null)
     {
         Write-Verbose ("WipeOutputs: "+$Directory+" "+(((Get-Volume ($DriveLetter=(Get-Item ".").PSDrive.Name)).SizeRemaining/1GB)))

Build-SampleSet.ps1

@@ -65,7 +65,7 @@ if (-not $env:GITHUB_REPOSITORY -eq '') {
 #
 elseif(Test-Path(".\packages")) {
     $build_environment=("NuGet")
-    $build_number=26066
+    $build_number=26095
 }
 #
 # EWDK sets environment variable BuildLab.  For example 'ni_release_svc_prod1.22621.2428'.
@@ -97,19 +97,15 @@ else {
 #
 # Samples must build cleanly and even without warnings.
 #
-# For this branch we handle this with infverif exclusions.
+# An exception is for infverif where specific warnings are acceptable.  Those
+# specific warnings indicates issues intentially present in the samples, that
+# anyone that clones the samples must fix as part of productizing a driver.
+# 
+# In 22621 those warnings are: /sw1284 /sw1285 /sw1293 /sw2083 /sw2086
+# 
+# After 22621 those warnings are put under a common flag: /samples
 #
-# In NI WDK the /msft flag excludes expected warnings.
-# This flag not to be used after NI.  Instead use /samples.
-#
-$InfVerif_AdditionalOptions=
-    (
-        $build_number -le 22621 ?
-        "/msft" :
-        "/samples /sw1199 /sw1204 /sw1208 /sw1233 /sw1402 /sw1423 /sw2084"
-    ) +
-    " " +
-    "/sw1203 /sw1205 /sw1296 /sw1324 /sw1420 /sw1421 /sw1422 /sw2083"
+$InfVerif_AdditionalOptions=($build_number -le 22621 ? "/sw1284 /sw1285 /sw1293 /sw2083 /sw2086" : "/samples")
 
 #
 # Determine exclusions.