Netvmin680 fix #805
Merged
Netvmin680 fix #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonknichel
requested changes
Dec 1, 2022
There was a problem hiding this comment.
@kahashimoto-ms - Thanks for this PR! We took a look and the changing of the destination directory of the sys files look fine but we have a request for the TextModeFlags registry value. This looks like something that text mode setup (Win2k and earlier way of installing Windows NT based OSes) would have looked at. We don't believe anything in the OS has read it for a long time, and if it was still reading it, it would be looking for it in the old location and not the new location you moved it to. Instead of moving the location of the TextModeFlags registry value, can you please remove it from the INF altogether? Thanks!
jasonknichel
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed driver isolation violations 1322 and 1323 for Netvmini680.inf.
Added missing #if directives for NDIS_SUPPORT_NDIS680 and redefined NIC_PHYSICAL_MEDIUM which was necessary to allow the driver to install.
Verified by installing on a VM and pinging the devices.