Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update primary color #723

Merged
merged 17 commits into from
Nov 20, 2024
Merged

Update primary color #723

merged 17 commits into from
Nov 20, 2024

Conversation

homing1
Copy link
Contributor

@homing1 homing1 commented Nov 14, 2024

Task: task-1012252

Link: preview

Affected components

$primary

  • card title color
  • pagination background
  • progress bar background
  • segmented controls font
  • steps background
  • toggle background
  • checkbox color
  • input, select, textarea focus border
  • button

$primary-background

  • message background
  • segmented controls hover background
  • primary tag background, border

$primary-dark

  • primary interactive tag color, hover

$primary-hover

  • accordion hover
  • pagination hover
  • segmented controls hover
  • primary tag hover

NEW
$primary-background-hover

  • primary interactive tag background hover

$primary-dark-hover

  • primary interactive tag hover

Testing

  1. Visit http://localhost:1111/components/button.html and http://localhost:1111/components/tag.html to review the main changes. Compare with Fluent's page https://react.fluentui.dev/?path=/docs/components-button-button--docs and existing Atlas design.atlas.microsoft.com
  2. Check all 3 themes.
  3. Review other affected components
  1. Accessibility scan passes, meaning that components meet contrast ratio on light and dark theme. Button and tag documentation page includes base and hover states. For other components, check hover states.

Additional information

[Optional]

Contributor checklist

  • Did you update the description of this pull request with a review link and test steps?
  • Did you submit a changeset? Changesets are required for all code changes.
  • Does your pull request implement complex UI logic (js/ts)? Consider adding an integration test to test your user flow.
  • Does your pull request add a new page to the documentation site? Add your new page for automated accessibility testing in /integration/tests/accessibility.

Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: 47e0b2d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@microsoft/atlas-css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

css/src/tokens/themes.scss Outdated Show resolved Hide resolved
css/src/tokens/themes.scss Outdated Show resolved Hide resolved
css/src/tokens/themes.scss Outdated Show resolved Hide resolved
@homing1 homing1 marked this pull request as ready for review November 19, 2024 01:55
@homing1 homing1 requested a review from a team as a code owner November 19, 2024 01:55
@homing1 homing1 changed the title [wip]Update primary color Update primary color Nov 19, 2024
wibjorn
wibjorn previously approved these changes Nov 19, 2024
wibjorn
wibjorn previously approved these changes Nov 20, 2024
@homing1 homing1 merged commit 0c61b76 into main Nov 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants