-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Banner and Notification components update #735
Open
ollips
wants to merge
8
commits into
main
Choose a base branch
from
olga/banner-notification-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+431
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollips
changed the title
Banner and Notification components update
[wip] Banner and Notification components update
Jan 9, 2025
🦋 Changeset detectedLatest commit: 3d7c9a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
homing1
reviewed
Jan 10, 2025
homing1
reviewed
Jan 10, 2025
ollips
changed the title
[wip] Banner and Notification components update
Banner and Notification components update
Jan 14, 2025
BenDMyers
reviewed
Jan 16, 2025
BenDMyers
reviewed
Jan 16, 2025
homing1
reviewed
Jan 16, 2025
homing1
reviewed
Jan 16, 2025
ollips
force-pushed
the
olga/banner-notification-update
branch
from
January 22, 2025 20:27
5e1645a
to
bdf78de
Compare
ellynliu
previously approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link: preview
Component:
Pattern:
Updating banner and notification components to match Fluent and creating pattern pages for them to showcase a few non-standard use cases.
Key points:
Testing
git checkout olga/banner-notification-update; npm start
Contributor checklist