Skip to content

Commit

Permalink
chore: update binskim to optout 4.3.1 version (#1077)
Browse files Browse the repository at this point in the history
This is new pre release version used in 1ES pipeline templates. But our
TSA upload task still uses the older version (1.9.5) so this conflict is
resulting into pipeline failure.

For now updating pipeline to optout for new version. 

There will be separate work item to update binskim to 4.3.1 version as
new rules in 4.3.1 might discover issues which also need to be resolved
so that pipeline does not break.

Co-authored-by: Bill Dengler <codeofdusk@gmail.com>
  • Loading branch information
v-viyada and codeofdusk authored Nov 30, 2024
1 parent e8841d5 commit 763d34b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions build/signedbuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ extends:
name: MSEngSS-MicroBuild2022-1ES
sdl:
binskim:
# #1077: Hold BinSkim back at 4.3.1 to resolve a pipeline incompatibility
preReleaseVersion: ''
# If you modify this list, you also need to modify the list in the Run BinSkim task in Signed Release Job or vice-versa to keep them in sync
analyzeTargetGlob: "$(System.DefaultWorkingDirectory)\\src\\CI\\bin\\**\\*.dll;\
$(System.DefaultWorkingDirectory)\\src\\Actions\\bin\\**\\*.dll;\
Expand Down

0 comments on commit 763d34b

Please sign in to comment.