Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx: add patch to fix MEDIUM CVE-2025-23419 #12286

Merged
merged 3 commits into from
Feb 14, 2025
Merged

nginx: add patch to fix MEDIUM CVE-2025-23419 #12286

merged 3 commits into from
Feb 14, 2025

Conversation

miz060
Copy link
Member

@miz060 miz060 commented Feb 11, 2025 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary

Added patch to fix CVE-2025-23419. Original fix: nginx/nginx@13935cf.

Parts of the patch in ngx_stream_ssl_module.c did not apply cleanly and were skipped, as Nginx 1.25.4 lacks the "Stream: virtual servers." commit. This means session resumption does not default to a shared SSL context, and ngx_stream_ssl_module.c already handles server name assignment explicitly. As a result, the cross-SNI session resumption restriction is unnecessary in this version.

Change Log
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging fasttrack/2.0 PRs Destined for AzureLinux 2.0 labels Feb 11, 2025
@miz060 miz060 marked this pull request as ready for review February 11, 2025 02:53
@miz060 miz060 requested a review from a team as a code owner February 11, 2025 02:53
@jslobodzian jslobodzian merged commit 99c2170 into fasttrack/2.0 Feb 14, 2025
9 checks passed
@jslobodzian jslobodzian deleted the mitchzhu/2-0-CVE-2025-23419 branch February 14, 2025 00:01
CBL-Mariner-Bot pushed a commit that referenced this pull request Feb 14, 2025
@miz060 @CBL-Mariner-Bot
nginx: add patch to fix MEDIUM CVE-2025-23419 (#12286)
f96aefb 
Co-authored-by: jslobodzian <joslobo@microsoft.com>
(cherry picked from commit 99c2170)
@CBL-Mariner-Bot CBL-Mariner-Bot mentioned this pull request Feb 14, 2025
Merged
@CBL-Mariner-Bot
Copy link
Collaborator

Auto cherry-pick results:

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=735675&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jslobodzian jslobodzian jslobodzian approved these changes

@Kanishk-Bansal Kanishk-Bansal Kanishk-Bansal approved these changes

Assignees
No one assigned
Labels
fasttrack/2.0 PRs Destined for AzureLinux 2.0 Packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miz060 @CBL-Mariner-Bot @jslobodzian @Kanishk-Bansal