Adds an entry point for the sbom-tool use the ScanCommand class. #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #936 +/- ##
=====================================
Coverage 74.9% 74.9%
=====================================
Files 235 235
Lines 9996 10002 +6
Branches 981 981
=====================================
+ Hits 7488 7494 +6
Misses 2234 2234
Partials 274 274 ☔ View full report in Codecov by Sentry. |
cobya
approved these changes
Dec 15, 2023
|
Thanks! @cobya I added unit tests since I saw the codecov comments. |
JamieMagee
approved these changes
Dec 18, 2023
tarun06
pushed a commit
to tarun06/component-detection
that referenced
this pull request
Jan 12, 2024
…rosoft#936) * Add Author/License to LinuxComponent * Add method to scan that returns a ScanResult Object * Revert "Add Author/License to LinuxComponent" This reverts commit 643dc09. * Add unit tests --------- Co-authored-by: Sebastian Gomez <segomez@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the ScanCommand class returns an int. In the sbom-tool we rely on the ScanResult object which forced us to go a step below and use the ScanExecution itself. This is causing us to miss out on a few features such as the ability to write a ScanManifest file (microsoft/sbom-tool#452).
This PR adds an extra method to the ScanCommand class that returns a ScanResult object instead of an int.
Let me know if there is more suitable name the current name is "ExecuteAsync" the method I added is "ExecuteScanAsync"