Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use ScanCommand Component Detection API #471

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

sfoslund
Copy link
Member

@sfoslund sfoslund commented Jan 5, 2024

This PR builds on @sebasgomez238's work in microsoft/component-detection#936 to add an entry point for us to use the ScanCommand class. Switching to this new class allows users to output the ScanManifest file by providing an extra parameter to the sbom-tool call. Example call: sbom-tool generate -b "C:/repos/test" -bc "C:/repos/test" -ps test -pn test -pv 1 -cd "--ManifestFile C:/repos/test/ScanManifest.json"

@sfoslund sfoslund requested a review from a team as a code owner January 5, 2024 21:00
@sfoslund sfoslund requested review from ksigmund and ByAgenT January 5, 2024 21:00
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (8d19e9f) 59.82% compared to head (9a3de2d) 59.78%.

Files Patch % Lines
src/Microsoft.Sbom.Api/Utils/ComponentDetector.cs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
- Coverage   59.82%   59.78%   -0.04%     
==========================================
  Files         248      248              
  Lines        7561     7566       +5     
  Branches      901      901              
==========================================
  Hits         4523     4523              
- Misses       2626     2631       +5     
  Partials      412      412              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfoslund sfoslund merged commit ce4e0f7 into microsoft:main Jan 5, 2024
6 checks passed
@sfoslund sfoslund deleted the sfoslund/ScanManifestOutput branch January 5, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants