Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally propagate source file root to Detector's scan request #1353

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

grvillic
Copy link
Contributor

Context

Custom detectors that inherit from IDetector can optionally access the SourceFileRoot property in the ScanRequest class.

This is useful if a custom detector wants to use placeholders of the reported file paths under certain conditions rather than just the source directory being scanned by the detector.

@grvillic grvillic requested a review from a team as a code owner January 27, 2025 06:21
@grvillic grvillic requested a review from pauld-msft January 27, 2025 06:21
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.6%. Comparing base (bdfdcd2) to head (73d5939).

Files with missing lines Patch % Lines
...r.Tests/Services/DetectorProcessingServiceTests.cs 96.1% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1353   +/-   ##
=====================================
  Coverage   89.6%   89.6%           
=====================================
  Files        384     384           
  Lines      29963   29990   +27     
  Branches    1835    1840    +5     
=====================================
+ Hits       26874   26900   +26     
  Misses      2698    2698           
- Partials     391     392    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grvillic grvillic enabled auto-merge (squash) January 27, 2025 06:49
@grvillic grvillic merged commit 2d5ecda into main Jan 27, 2025
22 of 25 checks passed
@grvillic grvillic deleted the users/grvillic/RelativePathFixes branch January 27, 2025 14:01
Copy link

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants