Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Pip TryAdd exception on duplicates #920

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Resolve Pip TryAdd exception on duplicates #920

merged 1 commit into from
Dec 1, 2023

Conversation

cobya
Copy link
Contributor

@cobya cobya commented Nov 30, 2023

Fixes #862 where multiple threads are attempting to parse the version RegEx at once and .Add failing due to duplicates.

@cobya cobya requested a review from a team as a code owner November 30, 2023 16:32
@cobya cobya requested a review from FernandoRojo November 30, 2023 16:32
@cobya cobya added type:bug Bug fix of existing functionality detector:pip The pip detector labels Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46cbc87) 74.8% compared to head (10131e5) 74.8%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #920   +/-   ##
=====================================
  Coverage   74.8%   74.8%           
=====================================
  Files        235     235           
  Lines       9941    9941           
  Branches     972     972           
=====================================
  Hits        7439    7439           
  Misses      2231    2231           
  Partials     271     271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cobya cobya merged commit b4def4c into main Dec 1, 2023
@cobya cobya deleted the cobya/PipKey branch December 1, 2023 16:54
Copy link

github-actions bot commented Dec 1, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detector:pip The pip detector type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SBOM issue is still there there is successful pipeline AI.Models.NL2Flow.MultiTurn Repo
3 participants