Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mocha trx reporter #106

Closed
wants to merge 1 commit into from
Closed

Conversation

jessetrinity
Copy link
Contributor

This open sources the mocha trx reporter dependency and publishes it to github packages for this repo. See https://github.com/microsoft/dev-tunnels/packages/1563273.

The ssh package also depends on this package. Once that has been open sourced in this repo as well, the vs package feed can also be removed.

@jasongin
Copy link
Member

This is not a good way to handle a fork of an open-source package... The correct way should be to fork the original repo and then apply the differences. That way the changes can be easily diffed and ported back and forth between the two forks.

@jessetrinity
Copy link
Contributor Author

jessetrinity commented Jul 27, 2022

This is not a good way to handle a fork of an open-source package... The correct way should be to fork the original repo and then apply the differences. That way the changes can be easily diffed and ported back and forth between the two forks.

If it was indeed a fork of mocha-trx-reporter then it was rewritten in TypeScript at some point and bears little resemblance. I don't even see the tests that the original has. Are we sure it was a fork of that repo and not just inspired by it (or a fork of some other repo)?

@jasongin
Copy link
Member

Hmm, I didn't realize it had diverged that much.

Can we consider moving to junit reporting instead, as suggested here? Then we won't have to add all this extra code.

@jessetrinity jessetrinity deleted the jessetrinity/addTrxReporter branch September 29, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants