Remove What's New page (#3952)

microsoft · Oct 21, 2024 · ae62bfd · ae62bfd
1 parent 5b5c143
commit ae62bfd
Show file tree

Hide file tree

Showing 29 changed files with 5 additions and 887 deletions.
diff --git a/common/Services/INavigationService.cs b/common/Services/INavigationService.cs
@@ -44,7 +44,6 @@ public static class KnownPageKeys
 {
     public static readonly string Dashboard = "DevHome.Dashboard.ViewModels.DashboardViewModel";
     public static readonly string Extensions = "DevHome.ExtensionLibrary.ViewModels.ExtensionLibraryViewModel";
-    public static readonly string WhatsNew = "DevHome.ViewModels.WhatsNewViewModel";
     public static readonly string Settings = "DevHome.Settings.ViewModels.SettingsViewModel";
     public static readonly string Feedback = "DevHome.Settings.ViewModels.FeedbackViewModel";
     public static readonly string Environments = "DevHome.Environments.ViewModels.LandingPageViewModel";

diff --git a/common/TelemetryEvents/DeveloperId/EntryPointEvent.cs b/common/TelemetryEvents/DeveloperId/EntryPointEvent.cs
@@ -24,16 +24,14 @@ public enum EntryPoint
         None = 0,
         Settings = 1,
         SetupFlow = 2,
-        WhatsNewPage = 3,
-        Widget = 4,
+        Widget = 3,
     }
 
     private readonly string[] _entryPointNames =
     [
         string.Empty,
         "Settings",
         "SetupFlow",
-        "WhatsNewPage",
         "Widget",
     ];
 

diff --git a/src/App.xaml.cs b/src/App.xaml.cs
@@ -155,7 +155,6 @@ public App()
             services.AddTransient<ShellPage>();
             services.AddTransient<InitializationPage>();
             services.AddTransient<ShellViewModel>();
-            services.AddTransient<WhatsNewViewModel>();
             services.AddTransient<InitializationViewModel>();
 
             // Settings

diff --git a/src/Assets/WhatsNewPage/DarkTheme/Background.png b/src/Assets/WhatsNewPage/DarkTheme/Background.png
diff --git a/src/Assets/WhatsNewPage/DarkTheme/DashboardHero.png b/src/Assets/WhatsNewPage/DarkTheme/DashboardHero.png
diff --git a/src/Assets/WhatsNewPage/DarkTheme/DevDriveHero.png b/src/Assets/WhatsNewPage/DarkTheme/DevDriveHero.png
diff --git a/src/Assets/WhatsNewPage/DarkTheme/DevIdHero.png b/src/Assets/WhatsNewPage/DarkTheme/DevIdHero.png
diff --git a/src/Assets/WhatsNewPage/DarkTheme/Extensions.png b/src/Assets/WhatsNewPage/DarkTheme/Extensions.png
diff --git a/src/Assets/WhatsNewPage/DarkTheme/ExtensionsBig.png b/src/Assets/WhatsNewPage/DarkTheme/ExtensionsBig.png
diff --git a/src/Assets/WhatsNewPage/LightTheme/Background.png b/src/Assets/WhatsNewPage/LightTheme/Background.png
diff --git a/src/Assets/WhatsNewPage/LightTheme/DashboardHero.png b/src/Assets/WhatsNewPage/LightTheme/DashboardHero.png
diff --git a/src/Assets/WhatsNewPage/LightTheme/DevDriveHero.png b/src/Assets/WhatsNewPage/LightTheme/DevDriveHero.png
diff --git a/src/Assets/WhatsNewPage/LightTheme/DevIdHero.png b/src/Assets/WhatsNewPage/LightTheme/DevIdHero.png
diff --git a/src/Assets/WhatsNewPage/LightTheme/Extensions.png b/src/Assets/WhatsNewPage/LightTheme/Extensions.png
diff --git a/src/Assets/WhatsNewPage/LightTheme/ExtensionsBig.png b/src/Assets/WhatsNewPage/LightTheme/ExtensionsBig.png
diff --git a/src/DevHome.csproj b/src/DevHome.csproj
@@ -57,10 +57,6 @@
   </ItemGroup>
 
   <ItemGroup>
-    <None Remove="Assets\WhatsNewPage\DarkTheme\Extensions.png" />
-    <None Remove="Assets\WhatsNewPage\DarkTheme\ExtensionsBig.png" />
-    <None Remove="Assets\WhatsNewPage\LightTheme\Extensions.png" />
-    <None Remove="Assets\WhatsNewPage\LightTheme\ExtensionsBig.png" />
     <None Remove="Styles\HyperlinkButton.xaml" />
     <None Remove="Styles\WindowTitleBar_ThemeResources.xaml" />
   </ItemGroup>

diff --git a/src/Models/WhatsNewCard.cs b/src/Models/WhatsNewCard.cs
diff --git a/src/Services/PageService.cs b/src/Services/PageService.cs
@@ -46,7 +46,6 @@ where assembly.GetName().Name == tool.Assembly
         this.ConfigureCustomizationPages();
 
         // Configure footer pages
-        Configure<WhatsNewViewModel, WhatsNewPage>();
         this.ConfigureExtensionLibraryPages();
         this.ConfigureSettingsPages();
 

diff --git a/src/Strings/en-us/Resources.resw b/src/Strings/en-us/Resources.resw
@@ -129,36 +129,6 @@
     <value>All files</value>
     <comment>Text for a dropdown option in a file picker dialog to show all files in a directory</comment>
   </data>
-  <data name="WhatsNewPage_DevIdCard.Description" xml:space="preserve">
-    <value>After you install an extension that connects one of your developer accounts to Dev Home, sign in to that account.</value>
-  </data>
-  <data name="WhatsNew.Content" xml:space="preserve">
-    <value>Introducing Dev Home</value>
-  </data>
-  <data name="WhatsNewPage_DevDriveCard.Description" xml:space="preserve">
-    <value>Optimize performance with a Dev Drive—Dev Home sets it up for you.</value>
-  </data>
-  <data name="WhatsNewPage_DevDriveCard.Title" xml:space="preserve">
-    <value>Create a Dev Drive</value>
-  </data>
-  <data name="WhatsNewPage_Description.Text" xml:space="preserve">
-    <value>Set up your machine, monitor your workflows, and access development utilities all from one centralized location.</value>
-  </data>
-  <data name="WhatsNewPage_DevDashCard.Description" xml:space="preserve">
-    <value>Get the info you need in one place—add widgets to track issues, pull requests, and system performance.</value>
-  </data>
-  <data name="WhatsNewPage_DevDashCard.Title" xml:space="preserve">
-    <value>Monitor projects in your dashboard</value>
-  </data>
-  <data name="WhatsNewPage_DevIdCard.Title" xml:space="preserve">
-    <value>Connect your developer account</value>
-  </data>
-  <data name="WhatsNewPage_NotifCard.Description" xml:space="preserve">
-    <value>Keep up with pull requests, checks, merges, and more.</value>
-  </data>
-  <data name="WhatsNewPage_NotifCard.Title" xml:space="preserve">
-    <value>Get timely notifications</value>
-  </data>
   <data name="InitializationPage_InfoDescription.Text" xml:space="preserve">
     <value>Monitor and track your coding tasks, workflows, system performance, and more on a customizable dashboard.</value>
   </data>
@@ -180,9 +150,6 @@
   <data name="InitializationPage_Title.Text" xml:space="preserve">
     <value>Dev Home is getting things ready for you...</value>
   </data>
-  <data name="WhatsNewPage_Title.Text" xml:space="preserve">
-    <value>Your development control center</value>
-  </data>
   <data name="Feedback_Title.Text" xml:space="preserve">
     <value>Feedback</value>
   </data>
@@ -192,24 +159,6 @@
   <data name="AppDisplayNameStable" xml:space="preserve">
     <value>Dev Home (Preview)</value>
   </data>
-  <data name="WhatsNewPage_DevDashCard.ButtonText" xml:space="preserve">
-    <value>Pin widgets</value>
-  </data>
-  <data name="WhatsNewPage_DevDriveCard.ButtonText" xml:space="preserve">
-    <value>Create Dev Drive</value>
-  </data>
-  <data name="WhatsNewPage_DevDriveCard.Link" xml:space="preserve">
-    <value>Learn more</value>
-  </data>
-  <data name="WhatsNewPage_DevIdCard.ButtonText" xml:space="preserve">
-    <value>Connect accounts</value>
-  </data>
-  <data name="WhatsNewPage_GetStartedButton.Content" xml:space="preserve">
-    <value>Get started</value>
-  </data>
-  <data name="WhatsNewPage_Header.Text" xml:space="preserve">
-    <value>Introducing Dev Home</value>
-  </data>
   <data name="WidgetProviderDisplayNameDev" xml:space="preserve">
     <value>Dev Home (Dev)</value>
     <comment>The display name for core widgets provider</comment>
@@ -234,18 +183,6 @@
     <value>Administrator: Dev Home (Preview)</value>
     <comment>Name of app when run as administrator</comment>
   </data>
-  <data name="WhatsNewPage_ExtensionsCard.ButtonText" xml:space="preserve">
-    <value>Explore extensions</value>
-    <comment>Button text on extensions card on "whats new" page</comment>
-  </data>
-  <data name="WhatsNewPage_ExtensionsCard.Description" xml:space="preserve">
-    <value>Extensions help you get more out of Dev Home. For example, get recommendations for other repositories to add when setting up your machine in Dev Home and add other widgets to your dashboard.</value>
-    <comment>Description of extensions card on "whats new" page</comment>
-  </data>
-  <data name="WhatsNewPage_ExtensionsCard.Title" xml:space="preserve">
-    <value>Explore Dev Home extensions</value>
-    <comment>Title of extensions card on "whats new" page</comment>
-  </data>
   <data name="WidgetDisplayNameCPU" xml:space="preserve">
     <value>CPU</value>
     <comment>Short name for the machine's Central Processing Unit.</comment>

diff --git a/src/ViewModels/ShellViewModel.cs b/src/ViewModels/ShellViewModel.cs
@@ -53,7 +53,7 @@ public ShellViewModel(
         screenReaderService.AnnouncementTextChanged += OnAnnouncementTextChanged;
     }
 
-    public async Task OnLoaded()
+    public void OnLoaded()
     {
         var activationKind = AppInstance.GetCurrent().GetActivatedEventArgs().Kind;
         Log.Information($"Activated with kind {activationKind}");
@@ -68,8 +68,7 @@ public async Task OnLoaded()
                 break;
             case ExtendedActivationKind.Launch:
             default:
-                var isNotFirstRun = await _localSettingsService.ReadSettingAsync<bool>(WellKnownSettingsKeys.IsNotFirstRun);
-                NavigationService.NavigateTo(isNotFirstRun ? NavigationService.DefaultPage : typeof(WhatsNewViewModel).FullName!);
+                NavigationService.NavigateTo(NavigationService.DefaultPage);
                 break;
         }
     }

diff --git a/src/ViewModels/WhatsNewViewModel.cs b/src/ViewModels/WhatsNewViewModel.cs
diff --git a/src/Views/ShellPage.xaml b/src/Views/ShellPage.xaml
@@ -62,12 +62,6 @@
                 <NavigationViewItem x:Uid="Shell_IGNORE" helpers:NavigationHelper.NavigateTo="DevHome.Settings.ViewModels.SettingsViewModel" Visibility="Collapsed"/>
             </NavigationView.MenuItems>
             <NavigationView.FooterMenuItems>
-                <NavigationViewItem x:Uid="WhatsNew" AutomationProperties.AutomationId="WhatsNew"
-                                    helpers:NavigationHelper.NavigateTo="DevHome.ViewModels.WhatsNewViewModel">
-                    <NavigationViewItem.Icon>
-                        <FontIcon FontFamily="{StaticResource SymbolThemeFontFamily}" Glyph="&#xE789;"/>
-                    </NavigationViewItem.Icon>
-                </NavigationViewItem>
                 <NavigationViewItem x:Uid="ms-resource:///DevHome.ExtensionLibrary/Resources/NavigationPane" AutomationProperties.AutomationId="Extensions"
                                     helpers:NavigationHelper.NavigateTo="DevHome.ExtensionLibrary.ViewModels.ExtensionLibraryViewModel">
                     <NavigationViewItem.Icon>