Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify all projects to use new RID definition #2531

Merged
merged 8 commits into from
Apr 9, 2024
Merged

Conversation

jaholme
Copy link
Contributor

@jaholme jaholme commented Apr 4, 2024

Summary of the pull request

This commit removes win10-xxx style RIDs from all csproj. It also updates all publishing profiles to support the .NET 8 style win-xxx RIDS.

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

Built x86/x64.

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@jaholme jaholme self-assigned this Apr 4, 2024
Update BuilDevSetupAgentHelper.ps1 to have correct output path with new RIDs
@krschau
Copy link
Collaborator

krschau commented Apr 4, 2024

@EricJohnson327 Can you remind me why we did the workarounds in the first place? Was it to play nice with WinAppSDK at the time?

@manodasanW
Copy link
Member

@EricJohnson327 Can you remind me why we did the workarounds in the first place? Was it to play nice with WinAppSDK at the time?

If I remember correctly, there are 2 issues which required the need for the RidGraph workaround:

  1. We hadn't updated to a Dev Home SDK package that was using the new runtime identifier format
  2. The adaptive cards package was also not using the new format and some binaries weren't getting picked up causing adaptive card issues.

We should confirm whether both issues have been addressed or not.

@krschau
Copy link
Collaborator

krschau commented Apr 4, 2024

If I remember correctly, there are 2 issues which required the need for the RidGraph workaround:

  1. We hadn't updated to a Dev Home SDK package that was using the new runtime identifier format
  2. The adaptive cards package was also not using the new format and some binaries weren't getting picked up causing adaptive card issues.

We should confirm whether both issues have been addressed or not.

Shoot, widgets don't render with this change. I've opened microsoft/AdaptiveCards#8868.

@krschau krschau marked this pull request as draft April 4, 2024 23:53
@jaholme jaholme marked this pull request as ready for review April 9, 2024 00:00
@jaholme
Copy link
Contributor Author

jaholme commented Apr 9, 2024

If I remember correctly, there are 2 issues which required the need for the RidGraph workaround:

  1. We hadn't updated to a Dev Home SDK package that was using the new runtime identifier format
  2. The adaptive cards package was also not using the new format and some binaries weren't getting picked up causing adaptive card issues.

We should confirm whether both issues have been addressed or not.

Shoot, widgets don't render with this change. I've opened microsoft/AdaptiveCards#8868.

This is solved with the latest set of changes. DevHome can manually copy the libraries to the package directory as a temporary workaround.

@jaholme jaholme merged commit 601cc3b into main Apr 9, 2024
4 checks passed
@krschau krschau added this to the Dev Home v0.13 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants