Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tooltip to config buttons #2559

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Adding tooltip to config buttons #2559

merged 6 commits into from
Apr 10, 2024

Conversation

dhoehna
Copy link
Contributor

@dhoehna dhoehna commented Apr 8, 2024 •
edited
Loading

Summary of the pull request

  1. The buttons on the repo config screen have a tool tip.
  2. Narrator says the repo name instead of the class name.
  3. Moved the "TextChanged" code out of code-behind and into the view model.

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

  1. Made a devdrive and cloned repos to it.
  2. Validated correct error handling in the folder picker text box.

Task

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

Movie!
RepoConfigButtonTooltips

@dhoehna dhoehna requested review from krschau, brialmsft, bbonaby and a team April 8, 2024 19:24
@dhoehna dhoehna merged commit ebfbe69 into main Apr 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krschau krschau krschau approved these changes

@vineeththomasalex vineeththomasalex vineeththomasalex approved these changes

@brialmsft brialmsft Awaiting requested review from brialmsft

@bbonaby bbonaby Awaiting requested review from bbonaby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhoehna @vineeththomasalex @krschau