Using Content in SecondaryWindow #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoehna
requested review from
jsidewhite,
nieubank,
huzaifa-d,
vineeththomasalex,
dkbennett,
jaholme,
krschau,
EricJohnson327,
sshilov7,
brialmsft,
hart-wilson,
SohamDas2021,
AmelBawa-msft,
bbonaby,
ssparach and
a team
krschau
reviewed
Apr 10, 2024
|
How does this behave with Narrator? |
With the one line fix (compared to the multi line fix) nothing. narrator works as expected. So does the tabbing order. |
dhoehna
changed the title
krschau
approved these changes
Apr 10, 2024
AmelBawa-msft
approved these changes
Apr 10, 2024
bbonaby
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
SecondaryWindow was using assigning _windowTemplate to WindowContent. WindowContent has
IsTabStopset toTrueand this was causing the phantom tab stop.The fix is to assign _windowTemplate to Content instead.
Using Content is okay in this instance because DevHome has our own custom title bar and content.
References and relevant issues
Task
Detailed description of the pull request / Additional comments
Validation steps performed
Manually tested
PR checklist