Customization craftsmanship review updates #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nieubank
added
Type-Craftsmanship
krschau
approved these changes
Apr 11, 2024
nieubank
force-pushed
the
user/nieubank/custcraft
branch
from
927e1be
to
4a68840
Compare
| @@ -271,10 +271,6 @@ | |||
| <value>This feature can be activated for 2 hours.</value> | |||
| <comment>A description of the Quiet Background Processes time window</comment> | |||
| </data> | |||
| <data name="QuietBackgroundProcessesExplanation.Header" xml:space="preserve"> | |||
There was a problem hiding this comment.
Since Main/Release/Staging branches all use the same resource files, we might want not want to remove these until we confirm it's not being used in the release branch.
@EricJohnson327
There was a problem hiding this comment.
It's not in release yet, but staging has these strings.
I'm not we'd want to ship with this string either way.
vineeththomasalex
approved these changes
Apr 12, 2024
dhoehna
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Misc. updates based on craftsmanship review
References and relevant issues
#2581
Detailed description of the pull request / Additional comments
Additionally, renamed some code behind files to make grouping work correctly in VS.
Validation steps performed
PR checklist