[FE + Version Control] Accessibility Insights Fast Pass: Section 508 502.3.1: (DevHome/button '') The Name property must not contain any characters in the private Unicode range. #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefaultRyan
approved these changes
Sep 5, 2024
ssparach
added
Needs-Second
vineeththomasalex
approved these changes
Sep 6, 2024
krschau
requested changes
Sep 6, 2024
tools/Customization/DevHome.Customization/Strings/en-us/Resources.resw
Outdated
Show resolved
Hide resolved
krschau
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
The PR fixes an accessibility issue in the Add Repositories UI under the Windows Customization File Explorer page.
References and relevant issues
#3665
Detailed description of the pull request / Additional comments
An accessible name was declared for the button through AutomationProperties.Name.
Validation steps performed
Local Build
Ensured that the issue no longer reproduces after the fix is applied using the Accessibility Insights for Windows tool. Some screenshots below:
Without fix the issue is identified in the tool:
With fix, the issue no longer appears
PR checklist