Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow scheme-less clone URLs #3792

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −3
Open

Allow scheme-less clone URLs #3792

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a8ea3e
Allow schemeless clone URLs
willibrandon Sep 6, 2024
85cc342
Use https for schemeless clone URLs
willibrandon Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tools/SetupFlow/DevHome.SetupFlow/ViewModels/AddRepoViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1184,7 +1184,7 @@ private void ValidateUriAndChangeUiIfBad(string url, out Uri uri)
uri = null;

// If the url isn't valid don't bother finding a provider.
if (!Uri.IsWellFormedUriString(url, UriKind.Absolute) ||
if (!Uri.IsWellFormedUriString(url, UriKind.RelativeOrAbsolute) ||
!Uri.TryCreate(url, UriKind.RelativeOrAbsolute, out uri))
{
UrlParsingError = _stringResource.GetLocalized(StringResourceKey.UrlValidationBadUrl);
Expand All @@ -1198,8 +1198,11 @@ private void ValidateUriAndChangeUiIfBad(string url, out Uri uri)
{
try
{
var uriBuilder = new UriBuilder(uri.OriginalString);
uriBuilder.Port = -1;
var uriBuilder = new UriBuilder(schemeName: Uri.UriSchemeHttps, hostName: uri.OriginalString)
{
Port = -1,
};

uri = uriBuilder.Uri;
}
catch (Exception e)
Expand Down
Loading