Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #3793

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Update README.md #3793

merged 3 commits into from
Sep 10, 2024

Conversation

ghost
Copy link

@ghost ghost commented Sep 6, 2024

Summary of the pull request

Changes the README.md file to say that Windows 10 is also supported by Dev Home.

References and relevant issues

Detailed description of the pull request / Additional comments

Based on the package manifest:

<TargetDeviceFamily Name="Windows.Desktop" MinVersion="10.0.19041.0" MaxVersionTested="10.0.22000.0" />

Validation steps performed

Not applicable

PR checklist

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Strong-pwned and others added 2 commits September 6, 2024 19:01
Co-authored-by: Kristen Schau <47155823+krschau@users.noreply.github.com>
@cinnamon-msft
Copy link
Contributor

Do we need Developer Mode enabled when compiling and building the repo? I think we might want to keep that item for folks who are developing

@krschau
Copy link
Collaborator

krschau commented Sep 9, 2024

Do we need Developer Mode enabled when compiling and building the repo? I think we might want to keep that item for folks who are developing

I figured we should remove it because 1) I actually don't think you need Developer Mode enabled. You may need it to sideload a built msix, but I think that's a less common way of building/installing than VS and 2) If we want to add it back in with those details, it should go in contributing.md

@adrastogi
Copy link
Contributor

I tested out F5'ing w/o Developer Mode enabled, and Visual Studio did tell me that I need to have it on to deploy it. So adding that requirement to the contributing.md sounds like a good idea.

image

@krschau
Copy link
Collaborator

krschau commented Sep 9, 2024

I tested out F5'ing w/o Developer Mode enabled, and Visual Studio did tell me that I need to have it on to deploy it. So adding that requirement to the contributing.md sounds like a good idea.

@adrastogi Thanks for trying this out. I opened #3818 to include the info over there.

@krschau krschau merged commit 7ddd036 into microsoft:main Sep 10, 2024
4 checks passed
@krschau krschau added this to the Dev Home v0.18 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README.md says Dev Home requires Windows 11
5 participants