-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up git submodule tests and delay Git status runner #3800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefaultRyan
requested review from
dhoehna,
vineeththomasalex,
EricJohnson327 and
ssparach
September 7, 2024 04:45
DefaultRyan
changed the title
Delay Git status runner and clean up Git tests
Clean up git submodule tests and delay Git status runner
Sep 9, 2024
extensions/GitExtension/FileExplorerGitIntegration/Models/GitLocalRepository.cs
Outdated
Show resolved
Hide resolved
vineeththomasalex
approved these changes
Sep 10, 2024
extensions/GitExtension/FileExplorerGitIntegration.UnitTest/GitCommandRunnerTests.cs
Outdated
Show resolved
Hide resolved
extensions/GitExtension/FileExplorerGitIntegration.UnitTest/GitSubmoduleUnitTests.cs
Outdated
Show resolved
Hide resolved
extensions/GitExtension/FileExplorerGitIntegration/Models/GitLocalRepository.cs
Outdated
Show resolved
Hide resolved
vineeththomasalex
approved these changes
Sep 10, 2024
ssparach
reviewed
Sep 10, 2024
ssparach
reviewed
Sep 10, 2024
return repository.FindLastCommit(relativePath); | ||
} | ||
catch | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: consider catching and logging exception here
ssparach
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
I noticed that the Git Extension unit tests were not running in CI. Also, while running them, I noticed certain things not getting cleaned up properly - I saw error messages from the "git status" as the test repo was being deleted, and the deletion often failed because a LibGit2Sharp.Repository was hanging on to some files under .git.
References and relevant issues
Detailed description of the pull request / Additional comments
On the cleanup side of things in the Git extension:
Validation steps performed
PR checklist