update environments telemetry to add hresults #3804
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Although we capture the error messaging, we don't capture the HResult error codes. Capturing these will provide us with more information that we can use to filter out noisy data a bit easier.
Changes:
TelemetryResult
class that extracts data from theProviderOperationResult
so this doesn't have to be done by all the other telemetry classes.EnvironmentOperationEvent
,EnvironmentCreationEvent
and theEnvironmentLaunchEvent
classes. These also now take aTelemetryResult
in their constructors to get the error information.References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
I used the TraceView++ app to confirm that the events are now submitting the HResults, that are received by the operations in their payload.
PR checklist