Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevDiagnostics Installed unhandled exception handler #3830

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

timkur
Copy link
Contributor

@timkur timkur commented Sep 10, 2024

Summary of the pull request

In investigating bug

Bug 53280185: ERROR_STATE_LOAD_STORE_FAILED in DevHome PI

it was unfortunate that there isn't enough information in the cab to diagnose the crash. I'm taking a page from DevHome proper here and installing an unhandled exception handler, which hopefully will be able to capture a little more information to make crash investigations more fruitful.

References and relevant issues

Detailed description of the pull request / Additional comments

Reproed the crash for #3826, saw this handled the exception and terminated properly.

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

Copy link
Contributor

@xhan65 xhan65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@timkur timkur merged commit c40f8f3 into main Sep 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants