Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the ability to toggle App Verifier in Image File Execution Options (IFEO) for the target app. #3840

Merged
merged 7 commits into from
Sep 16, 2024

Conversation

aeloros
Copy link
Contributor

@aeloros aeloros commented Sep 11, 2024

Summary of the pull request

Add's a new internal tool on the bar for enabling AppVerifier, and possibly other Image File Execution Options (IFEO) in the future.

Detailed description of the pull request / Additional comments

Provided a Window that runs elevated with toggle switches to enable/disable options. Currently the UI is the only thing limiting new options being added, and AppVerifier is the only current option included.

The intention is that since AppVerifier produces WER dumps, they (the results) will show up in that section of the UI for viewing purposes.

Validation steps performed

Manual scenario smoke tests

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

No service, No Elevation!

remove stale comment

initial plug at a separate tool exe

New tool app creation checkpoint.

more telemetry

more telemetry, and basic arg parsing

per-targetapp instancing

remove todo
@timkur
Copy link
Contributor

timkur commented Sep 12, 2024

Add a screenshot of your new tool in the PR description. Show off your handiwork! :)

@timkur
Copy link
Contributor

timkur commented Sep 12, 2024

// Copyright (c) Microsoft Corporation.

Hmm.... looks like all the line endings changed in this file. Is this moving everything to CRLF, or are things getting messed up?


Refers to: common/Helpers/RegistryWatcher.cs:1 in ff16209. [](commit_id = ff16209, deletion_comment = False)

@aeloros
Copy link
Contributor Author

aeloros commented Sep 12, 2024

// Copyright (c) Microsoft Corporation.

Hmm.... looks like all the line endings changed in this file. Is this moving everything to CRLF, or are things getting messed up?

Refers to: common/Helpers/RegistryWatcher.cs:1 in ff16209. [](commit_id = ff16209, deletion_comment = False)

No idea TBH, as I only ever used either VS, VSCode, or Git for all of my operations. Any suggestions on what to look for to identify, fix, and prevent? Seems like a common issue....

Copy link
Contributor

@jaholme jaholme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aeloros aeloros merged commit e06682b into main Sep 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants