durable task scheduler auth extension support #362
Conversation
save initial
|
@jviau would you mind taking a look at this as well? The main feedback I'm interested in from you is the package name/organization. The idea behind this PR is to introduce a mechanism for configuring the gRPC channels to work with the Durable Task Scheduler (DTS). This includes setting up the appropriate auth and some other service-specific headers (like the task hub name). I figured this might be the right time to introduce an "Extensions" concept and make "Azure" the extension consumers should use for talking to DTS. There could be others in the future. WDYT? |
This reverts commit 131c575.
| return new ArgumentException(message: $"Required option '{optionName}' was not provided."); | ||
| } | ||
|
|
||
| sealed class TokenCache(TokenCredential credential, TokenRequestContext context, TimeSpan margin) |
There was a problem hiding this comment.
Did you look into Azure.Identity library to see if they already do token caching?
There was a problem hiding this comment.
I found this: maybe you can copy and adapt it for usage here: https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/Azure.Core/src/Pipeline/BearerTokenAuthenticationPolicy.cs#L219
There was a problem hiding this comment.
https://github.com/Azure/azure-sdk-for-net/blob/8992dc64edcedebcbde48e33f376d8489e4a8d19/sdk/identity/Azure.Identity/samples/TokenCache.md
https://azuresdkdocs.blob.core.windows.net/%24web/dotnet/Azure.Identity/1.13.1/index.html?utm_source=chatgpt.com
yes i checked azure.identity 1.31.1 doc mentions
Thread safety
We guarantee that all credential instance methods are thread-safe and independent of each other (guideline). This ensures that the recommendation of reusing credential instances is always safe, even across threads.
also default it use in memory cache. our current implementation dont need reimplement these.
AzureCliCredential does not support that but i believe running from local does not need high load, correct me if i am wrong
I wonder if we want a name other that Extensions for backends? I am worried this may get confused with a backend vs helpers for Azure / a specific Azure service. Say we wanted to port an AzureStorage backend hook to durable - where would that go? Or if we wanted to introduce helpers (not backends) for interacting with Azure services (Compute, Storage, CosmosDB, etc). Where would those go? There is the This also brings up the point of keeping a separate Worker and Client package. While it is more setup work on our end, the benefit is customers can bring in just the clients for their API projects and not need the entire worker. |
any advice on jacob's comment @cgillum ? |
|
@jviau thanks for all the comments! i updated the pr and its ready for another review, added more tests and tested it manually with sample and working |
@jviau this makes sense to me. How about this - there will be two new nuget packages:
I prefer "AzureManaged" over "Azure" because "Azure" becomes ambiguous if we ever wanted to introduce "AzureStorage" or something similar as a backend option for this SDK in the future. @YunchuWang in terms of project structure, how about this?
The |
This pull request introduces a new set of Azure extensions for the Durable Task Framework, including project setup, implementation of core classes and methods, and unit tests. The most important changes include adding new projects to the solution, defining the core classes and methods for Azure integration, and creating unit tests to ensure the functionality of the new extensions.
Project Setup:
ExtensionsandAzureto the solutionMicrosoft.DurableTask.slnand configured their build settings. [1] [2] [3]Core Implementation:
Azure.csprojfile to define the Azure extensions project, including dependencies and target frameworks.DurableTaskSchedulerConnectionStringclass to parse and manage connection strings for the Durable Task Scheduler service.DurableTaskSchedulerExtensionsclass with methods to configure Durable Task Worker and Client to use the Durable Task Scheduler service.DurableTaskSchedulerOptionsclass to encapsulate configuration options for the Durable Task Scheduler.Unit Tests:
DurableTaskSchedulerConnectionStringTests.csto validate the parsing and handling of connection strings.