Fix #30: Add 256 color support for Terminal.app on macOS #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@microsoft-github-policy-service agree |
lhecker
reviewed
Jun 30, 2025
| _ = write!(dst, "\x1b[{typ}8;2;{r};{g};{b}m"); | ||
| } | ||
| ColorMode::Color256 => { | ||
| let index: u8 = if r == g && g == b { |
There was a problem hiding this comment.
I think the grayscale detection is a little brittle. It may be better to convert the 216+24 colors to Oklab and store them in a list here. Then we can search linearly through it and find the closest coordinate and its index.
While writing a 4D matcher I found that Rust is entirely unable to optimize [f32; 4] operations from MOVSS to MOVPS under opt-level=s which is quite disappointing to learn. I suppose I should hurry my custom stdlib collection reimplementation so we can switch back to opt-level=3 sooner rather than later.
Edit: Filed as rust-lang/rust#143242
All that aside, I would prefer if the entire code is only compiled under cfg(target_platform = "macos").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 256 color support for the current version of apple terminal that doesn't support truecolor. For now, I only added support for terminal.app, since as discussed in #30, apple's terminal is likely the only modern terminal that doesn't support truecolor.
I understand apple is adding support for truecolor in MacOS Tahoe, but it will likely be quite some time before most mac users update, and and I'd like to enjoy edit right now without updating to the beta OS.
Fixes #30