Fix: Include all Windows VMs in Azure Hybrid Benefit workbooks regardless of publisher

[Copilot]

Problem

Windows VMs from publishers other than MicrosoftWindowsServer and microsoftsqlserver (e.g., esri, safesoftwareinc) were not appearing in the Azure Hybrid Benefit (AHB) workbooks, preventing users from getting a complete view of their Windows VMs for AHB optimization.

Root Cause

The KQL queries in the AHB workbooks filtered VMs based on specific publishers rather than checking the OS type. The problematic filter was:

where tostring(properties.storageProfile.imageReference.publisher) == "MicrosoftWindowsServer" 
   or tostring(properties.virtualMachineProfile.storageProfile.osDisk.osType) == 'Windows' 
   or tostring(properties.storageProfile.imageReference.publisher) == "microsoftsqlserver"

This approach had two issues:

1. It only checked osType for Virtual Machine Scale Sets (VMSS), not for regular VMs
2. It excluded Windows VMs from third-party publishers like esri and safesoftwareinc

Solution

Updated all affected queries to check the OS type for both regular VMs and VMSS:

where tostring(properties.storageProfile.osDisk.osType) == 'Windows' 
   or tostring(properties.virtualMachineProfile.storageProfile.osDisk.osType) == 'Windows'

This change aligns with the Azure Hybrid Benefit documentation which states: "All Windows Server OS-based images are supported for Azure Hybrid Benefit for Windows Server" - regardless of the publisher.

Changes Made

• Updated 4 queries in src/workbooks/optimization/AHB/AHB.workbook
• Updated 2 queries in src/workbooks/optimization/Compute/AHB.workbook
• Added changelog entry documenting the fix

Impact

After this fix, the AHB workbooks will now correctly display:

• ✅ Windows VMs from any publisher (including esri, safesoftwareinc, and custom images)
• ✅ Windows VMs from MicrosoftWindowsServer publisher (existing functionality preserved)
• ✅ Windows VMs from microsoftsqlserver publisher (existing functionality preserved)
• ✅ Windows Virtual Machine Scale Sets (existing functionality preserved)
• ✅ Excludes Linux VMs correctly (no false positives)

This provides users with a complete and accurate view of all their Windows VMs eligible for Azure Hybrid Benefit, enabling better cost optimization decisions.

Related Issues

Fixes #1849

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Windows VMs based on other images are not present in the Hybrid Benefits overviews</issue_title>
<issue_description>## 🐛 Problem
It seems that for AHB for Windows VMs images like the image from publishers esri and safesoftwareinc are not taken into account, so don't appear on any overview.

🤔 Expected

I expect all VMs with windows server to be taken into account, also from other publishers.

</issue_description>

<agent_instructions>Triage the issue, research using mslearn, provide proposed solutions along with links/citations to authorative sources.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@arthurclares @pvansteenkiste Is this for the Cost Optimization Workbook or for the Power BI reports?

Fixes #1793

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.