Skip to content

Conversation

@leddie24
Copy link
Collaborator

@leddie24 leddie24 commented Oct 30, 2025

Previous Behavior

Current Checkbox and Radio controls have no animation/transition on click/selection

New Behavior

This PR adds in a transition effect on selection

Related Issue(s)

  • Fixes #

@leddie24 leddie24 changed the title Checkbox and Radio components motion [wip] Checkbox and Radio components motion Oct 30, 2025
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-checkbox
Checkbox
34.431 kB
11.803 kB
35.71 kB
12.141 kB
1.279 kB
338 B
react-components
react-components: entire library
1.279 MB
321.377 kB
1.28 MB
321.854 kB
1.461 kB
477 B
react-list
ListItem
112.496 kB
33.256 kB
113.775 kB
33.593 kB
1.279 kB
337 B
react-radio
Radio
31.817 kB
10.007 kB
31.999 kB
10.069 kB
182 B
62 B
react-table
DataGrid
161.193 kB
45.568 kB
162.654 kB
45.96 kB
1.461 kB
392 B
react-table
Table as DataGrid
131.516 kB
36.36 kB
132.979 kB
36.715 kB
1.463 kB
355 B
react-table
Table (Selection only)
69.904 kB
19.72 kB
71.365 kB
20.084 kB
1.461 kB
364 B
react-table
Table (Sort only)
68.547 kB
19.334 kB
70.008 kB
19.701 kB
1.461 kB
367 B
react-tree
FlatTree
149.09 kB
42.662 kB
150.551 kB
43.02 kB
1.461 kB
358 B
react-tree
PersonaFlatTree
149.848 kB
42.793 kB
151.309 kB
43.142 kB
1.461 kB
349 B
react-tree
PersonaTree
146.113 kB
41.654 kB
147.574 kB
42.003 kB
1.461 kB
349 B
react-tree
Tree
145.363 kB
41.53 kB
146.822 kB
41.886 kB
1.459 kB
356 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
68.813 kB
19.905 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
236.652 kB
68.58 kB
react-components
react-components: FluentProvider & webLightTheme
43.647 kB
14.259 kB
react-list
List
88.914 kB
26.39 kB
react-portal-compat
PortalCompatProvider
8.386 kB
2.624 kB
react-radio
RadioGroup
14.906 kB
6.091 kB
react-table
Table (Primitives only)
41.992 kB
13.576 kB
react-timepicker-compat
TimePicker
109.948 kB
36.338 kB
🤖 This report was generated against 5863b2accfe7e02beb2af3459c1ee0c79cc1ee30

@github-actions
Copy link

Pull request demo site: URL

@@ -0,0 +1,7 @@
{
Copy link

@github-actions github-actions bot Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-react-components/Avatar Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Avatar Converged.badgeMask - RTL.normal.chromium.png 6 Changed
vr-tests-react-components/Avatar Converged.badgeMask.normal.chromium.png 5 Changed
vr-tests-react-components/Charts-DonutChart 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png 12635 Changed
vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png 27053 Changed
vr-tests-react-components/Positioning 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png 493 Changed
vr-tests-react-components/Positioning.Positioning end.chromium.png 585 Changed
vr-tests-react-components/TagPicker 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png 1321 Changed
vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png 635 Changed

There were 2 duplicate changes discarded. Check the build logs for more information.

@leddie24 leddie24 marked this pull request as ready for review November 3, 2025 18:45
@leddie24 leddie24 requested review from a team, mainframev and spmonahan as code owners November 3, 2025 18:45
@leddie24 leddie24 changed the title [wip] Checkbox and Radio components motion Checkbox and Radio components motion Nov 3, 2025
@marcosmoura
Copy link
Contributor

marcosmoura commented Nov 3, 2025

@leddie24 Thank you for your contribution. This is a topic that is already in progress, and should be released quite soon. You can keep track of the progress here:

#35319
#35380

@leddie24 leddie24 force-pushed the edwl/fluent-checkbox-radio-motion branch from de8f26a to 4b90b67 Compare November 4, 2025 17:35
@leddie24
Copy link
Collaborator Author

leddie24 commented Nov 6, 2025

@leddie24 Thank you for your contribution. This is a topic that is already in progress, and should be released quite soon. You can keep track of the progress here:

#35319 #35380

Hi @marcosmoura, thanks for letting me know! Could you help me understand who's coordinating this work? I was asked to implement these changes by Casey Baker, but it seems there may be some overlap here.

To avoid duplicating efforts in the future, what's the best way to check if motion work is already in progress before I start? I'd like to make sure we're aligned as I continue contributing motion updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants