Skip to content

refactor(react-divider): reduce bundle size by removing the getIntrinsicElementProps helper #35540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dmytrokirpa wants to merge 2 commits into
base: master
Choose a base branch
from
+13 −5
Draft

refactor(react-divider): reduce bundle size by removing the getIntrinsicElementProps helper #35540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d79ad91
refactor(react-divider): reduce bundle size by removing the getIntrin…
dmytrokirpa Dec 4, 2025
dc5db52
change
dmytrokirpa Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-divider-a68ce562-55b2-4c91-80ca-f4c8d1fb48f7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Copy link

@github-actions github-actions bot Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-react-components/CalendarCompat 4 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png 1229 Changed
vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png 404 Changed
vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png 1108 Changed
vr-tests-react-components/CalendarCompat.multiDayView - RTL.default.chromium.png 495 Changed
vr-tests-react-components/Positioning 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Positioning.Positioning end.chromium.png 510 Changed
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png 74 Changed
vr-tests-react-components/TagPicker 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png 1319 Changed

There were 2 duplicate changes discarded. Check the build logs for more information.

"type": "patch",
"comment": "refactor: reduce bundle size by removing the getIntrinsicElementProps helper",
"packageName": "@fluentui/react-divider",
"email": "dmytrokirpa@microsoft.com",
"dependentChangeType": "patch"
}
1 change: 1 addition & 0 deletions ...mponents/react-divider/library/src/components/Divider/__snapshots__/Divider.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ exports[`Divider renders a divider with a different color 1`] = `
<div
aria-orientation="horizontal"
class="fui-Divider"
color="#FF00FF"
role="separator"
/>
`;
Expand Down
10 changes: 5 additions & 5 deletions packages/react-components/react-divider/library/src/components/Divider/useDivider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { getIntrinsicElementProps, useId, slot } from '@fluentui/react-utilities';
import { useId, slot } from '@fluentui/react-utilities';
import type { DividerProps, DividerState } from './Divider.types';

/**
Expand All @@ -8,7 +8,7 @@ import type { DividerProps, DividerState } from './Divider.types';
* @param ref - User-provided ref to be passed to the Divider component.
*/
export const useDivider_unstable = (props: DividerProps, ref: React.Ref<HTMLElement>): DividerState => {
const { alignContent = 'center', appearance = 'default', inset = false, vertical = false, wrapper } = props;
const { alignContent = 'center', appearance = 'default', inset = false, vertical = false, wrapper, ...rest } = props;
const dividerId = useId('divider-');

return {
Expand All @@ -25,16 +25,16 @@ export const useDivider_unstable = (props: DividerProps, ref: React.Ref<HTMLElem
},

root: slot.always(
getIntrinsicElementProps('div', {
{
role: 'separator',
'aria-orientation': vertical ? 'vertical' : 'horizontal',
'aria-labelledby': props.children ? dividerId : undefined,
...props,
...rest,
// FIXME:
// `ref` is wrongly assigned to be `HTMLElement` instead of `HTMLDivElement`
// but since it would be a breaking change to fix it, we are casting ref to it's proper type
ref: ref as React.Ref<HTMLDivElement>,
} as const),
} as React.HTMLAttributes<HTMLDivElement>,
{ elementType: 'div' },
),
wrapper: slot.always(wrapper, {
Expand Down