Skip to content

feat(react-menu): expose base hooks and types for Menu item components #35900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dmytrokirpa wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat(react-menu): expose base hooks and types for Menu item components #35900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
262a99b
feat(react-menu): expose base hooks and types for Menu item components
dmytrokirpa Mar 25, 2026
3fffb74
Merge branch 'master' into feat/react-menu-expose-base-hooks
dmytrokirpa Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-menu-1e3a8f69-d8b8-4efa-abd9-99c3e6e8d1f4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Copy link
Copy Markdown

@github-actions github-actions bot Mar 25, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-react-components/Avatar Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Avatar Converged.badgeMask - RTL.normal.chromium.png 6 Changed
vr-tests-react-components/CalendarCompat 4 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png 3349 Changed
vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png 849 Changed
vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png 3308 Changed
vr-tests-react-components/CalendarCompat.multiDayView.default.chromium.png 858 Changed
vr-tests-react-components/Charts-DonutChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Charts-DonutChart.Dynamic - Dark Mode.default.chromium.png 7530 Changed
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png 404 Changed
vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png 413 Changed
vr-tests-react-components/Positioning 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Positioning.Positioning end.chromium.png 504 Changed
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png 140 Changed
vr-tests-react-components/ProgressBar converged 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png 51 Changed
vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png 26 Changed
vr-tests-react-components/TagPicker 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/TagPicker.disabled - RTL.disabled input hover.chromium.png 635 Changed
vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png 1319 Changed

There were 3 duplicate changes discarded. Check the build logs for more information.

"type": "minor",
"comment": "feat: expose base hooks for Menu item components",
"packageName": "@fluentui/react-menu",
"email": "dmytrokirpa@microsoft.com",
"dependentChangeType": "patch"
}
18 changes: 18 additions & 0 deletions packages/react-components/react-menu/library/etc/react-menu.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,12 @@ export type MenuItemProps = Omit<ComponentProps<Partial<MenuItemSlots>>, 'conten
// @public
export const MenuItemRadio: ForwardRefComponent<MenuItemRadioProps>;

// @public
export type MenuItemRadioBaseProps = MenuItemRadioProps;

// @public
export type MenuItemRadioBaseState = MenuItemRadioState;

// @public (undocumented)
export const menuItemRadioClassNames: SlotClassNames<Omit<MenuItemSlots, 'submenuIndicator'>>;

Expand Down Expand Up @@ -515,9 +521,15 @@ export const useMenuGroupStyles_unstable: (state: MenuGroupState) => MenuGroupSt
// @public
export const useMenuItem_unstable: (props: MenuItemProps, ref: React_2.Ref<ARIAButtonElement<"div">>) => MenuItemState;

// @internal
export const useMenuItemBase_unstable: (props: MenuItemProps, ref: React_2.Ref<ARIAButtonElement<"div">>) => MenuItemState;

// @public
export const useMenuItemCheckbox_unstable: (props: MenuItemCheckboxProps, ref: React_2.Ref<ARIAButtonElement<"div">>) => MenuItemCheckboxState;

// @internal
export const useMenuItemCheckboxBase_unstable: (props: MenuItemCheckboxProps, ref: React_2.Ref<ARIAButtonElement<"div">>) => MenuItemCheckboxState;

// @public (undocumented)
export const useMenuItemCheckboxStyles_unstable: (state: MenuItemCheckboxState) => MenuItemCheckboxState;

Expand All @@ -530,6 +542,9 @@ export const useMenuItemLinkStyles_unstable: (state: MenuItemLinkState) => MenuI
// @public
export const useMenuItemRadio_unstable: (props: MenuItemRadioProps, ref: React_2.Ref<ARIAButtonElement<"div">>) => MenuItemRadioState;

// @internal
export const useMenuItemRadioBase_unstable: (props: MenuItemRadioBaseProps, ref: React_2.Ref<ARIAButtonElement<"div">>) => MenuItemRadioBaseState;

// @public (undocumented)
export const useMenuItemRadioStyles_unstable: (state: MenuItemRadioState) => void;

Expand All @@ -539,6 +554,9 @@ export const useMenuItemStyles_unstable: (state: MenuItemState) => MenuItemState
// @public
export const useMenuItemSwitch_unstable: (props: MenuItemSwitchProps, ref: React_2.Ref<HTMLDivElement>) => MenuItemSwitchState;

// @internal
export const useMenuItemSwitchBase_unstable: (props: MenuItemSwitchProps, ref: React_2.Ref<HTMLDivElement>) => MenuItemSwitchState;

// @public
export const useMenuItemSwitchStyles_unstable: (state: MenuItemSwitchState) => MenuItemSwitchState;

Expand Down
7 changes: 6 additions & 1 deletion packages/react-components/react-menu/library/src/MenuItemRadio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
export type { MenuItemRadioProps, MenuItemRadioState } from './components/MenuItemRadio/index';
export type {
MenuItemRadioProps,
MenuItemRadioState,
MenuItemRadioBaseProps,
MenuItemRadioBaseState,
} from './components/MenuItemRadio/index';
export {
MenuItemRadio,
menuItemRadioClassNames,
Expand Down
10 changes: 5 additions & 5 deletions packages/react-components/react-menu/library/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ export {

export type { MenuItemSwitchProps, MenuItemSwitchState, MenuItemSwitchSlots } from './MenuItemSwitch';

// Experimental: Base hooks - will be enabled in the experimental release branch
// export { useMenuItemBase_unstable } from './MenuItem';
// export { useMenuItemCheckboxBase_unstable } from './MenuItemCheckbox';
// export { useMenuItemRadioBase_unstable } from './MenuItemRadio';
// export { useMenuItemSwitchBase_unstable } from './MenuItemSwitch';
export { useMenuItemBase_unstable } from './MenuItem';
export { useMenuItemCheckboxBase_unstable } from './MenuItemCheckbox';
export { useMenuItemRadioBase_unstable } from './MenuItemRadio';
export type { MenuItemRadioBaseProps, MenuItemRadioBaseState } from './MenuItemRadio';
export { useMenuItemSwitchBase_unstable } from './MenuItemSwitch';
Loading