Fix running Confidential ContainerPlat #2484
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We discovered that running ContainerPlat using hcsshim/main was broken
A bisection pointed at this commit 8d81359
Rebuilding and using containerd-shim-runhcs-v1.exe solves the original issue I saw below but presented a new one.
When we parse
HostComputeEndpoint
into anLCOWNetworkAdapter
inconvertToLCOWReq()
the endpoint has a default route (0.0.0.0/0) where the NextHop field is an empty string, which I believe is invalid, it either needs to be a real gateway or the empty gateway. I traced it back to the construction of the endpoint structure inhcnendpoint.go#getEndpoint()
and saw the raw dataWhile we might still be able to fix the empty string at source, I think fixing the parsing to ignore invalid routes like this is a suitable defensive approach either way.