-
Notifications
You must be signed in to change notification settings - Fork 50
Add 8-bit integers back. #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of notes remaining from me.
Can someone please re-run the CLA thing? It should be resolved on my end. |
Please follow the instructions in the comment it posted. |
CLA bot should be pleased now? I should have been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, CLA bot seems happy now.
Will need the header updated and the text formatted to 80 columns before we can accept this.
The comment around tying it to cooperative vectors can take or leave for now.
|
||
## Introduction | ||
|
||
This proposal introduces 8-bit integer types to HLSL, to align it more closely with C/C++ and other languages, and allow tight interop with the 8-bit types used in the cooperative vector proposal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please format to 80 columns.
|
||
## Introduction | ||
|
||
This proposal introduces 8-bit integer types to HLSL, to align it more closely with C/C++ and other languages, and allow tight interop with the 8-bit types used in the cooperative vector proposal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the cooperative vector proposal has been rejected it might be better reframe this proposal. Does it still make sense when combined with the linear algebra matrix proposal? Does this proposal bring enough benefits on its own without tying it to another one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's somewhat orthogonal (8-bit types have value on their own), but it's obviously help LinAlg too instead of using packed types there. I'll rephrase.
Co-authored-by: Damyan Pepper <damyanp@microsoft.com>
Allow
i8
andu8
types, which are useful for pre-processing/post-processing data used in cooperative matrix/vector operations. Right now it's really ugly to unpack/pack viai32
. This proposal enablesi8
andu8
as native types in the shader core.