[NNNN] proposal to disallow explicit conversions for inout params #643
Conversation
|
|
||
| ## Introduction | ||
|
|
||
| DXC allows explicitly casting an array of type T to a vector of type T as an inout parameter. |
There was a problem hiding this comment.
I would swap the contents of the "Proposed Solution" and "Introduction" sections.
A one sentence introduction gives a good summary of the proposal, and your examples here give a more concrete understanding of the proposal and why it matters.
There was a problem hiding this comment.
I sort of did that, but ended up moving the examples to motivation, but I was still more verbose in the introduction.
Co-authored-by: Damyan Pepper <damyanp@microsoft.com>
| @@ -0,0 +1,112 @@ | |||
| --- | |||
| title: "NNNN - Disallow all explicit conversions in inout parameters" | |||
There was a problem hiding this comment.
Consider changing the proposal to be more general, like "Disallow all explicit conversions from producing an LValue"
|
|
||
| DXC inconsistently allows some C style explicit casts to produce LValues and be | ||
| used as arguments for inout parameters. However, C style explicit casts do not | ||
| produce LValues and inout parameters require LValues. |
There was a problem hiding this comment.
Consider adding that HLSL should mimic C++ behavior as closely as possible, so because C++ doesn't allow LValues as a result of these casts, HLSL shouldn't either.
4 participants
A proposal to disallow explicit conversions for inout parameters.