Conversation
baywet
commented
Apr 17, 2025
baywet
commented
Apr 17, 2025
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Member
Author
|
failures of test_and_generate_binaries (win-arm64, windows-11-arm) are expected. This is because the test is poorly designed and attempts to download the binaries from GitHub directly, which obviously fails in this case since we haven't released that architecture yet. A better test design would have been to use zip the local build, and use dotnet serve to serve this locally + an environment variable based override. |
baywet
commented
Apr 17, 2025
Member
Author
|
demonstrated as building here https://microsoftgraph.visualstudio.com/Graph%20Developer%20Experiences/_build/results?buildId=185804&view=results |
Member
Author
|
after merging, this needs to also be merged. MicrosoftDocs/openapi-docs#152 |
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
petrhollayms
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6427