Add support for AN NIC without a linked synthetic device #4074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle enable/disable test cases Handle PCI NIC count
adityagesh
commented
Oct 27, 2025
Comment on lines
529
to
553
| # Try to find the PCI slot for this NIC by checking its device path | ||
| result = self._node.execute( | ||
| f"readlink -f /sys/class/net/{nic_name}/device", | ||
| shell=True, | ||
| ) | ||
| if result.exit_code == 0 and result.stdout.strip(): | ||
| # Extract PCI slot from device path | ||
| # Path format: /sys/devices/.../XXXX:XX:XX.X/net/nicname | ||
| match = self.__pci_slot_pattern.search(result.stdout) | ||
| if match: | ||
| pci_slot = match.group(1) | ||
| # Get the module name for this PCI device | ||
| try: | ||
| module_name = lspci.get_used_module(pci_slot) | ||
| if module_name: | ||
| nic.pci_slot = pci_slot | ||
| # For standalone PCI NICs, set module_name directly | ||
| # (no lower_module_name since there's no lower device) | ||
| nic.module_name = module_name | ||
| self._node.log.debug( | ||
| f"Associated unpaired NIC {nic_name} " | ||
| f"with PCI slot {pci_slot} (module: {module_name})" | ||
| ) | ||
| else: | ||
| self._node.log.debug( |
Collaborator
Author
There was a problem hiding this comment.
I am not sure if this is the right place for this code.
If it is the right place, is it sufficient to just move the below code to a tool?
result = self._node.execute(
f"readlink -f /sys/class/net/{nic_name}/device",
shell=True,
)
# Path format: /sys/devices/.../XXXX:XX:XX.X/net/nicname
match = self.__pci_slot_pattern.search(result.stdout)
if match:
pci_slot = match.group(1)
Member
There was a problem hiding this comment.
yes, use tool is always better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.