Scan chrony drop-in replacement files for verify_timesync_ptp test #4120
+16
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update chrony configuration file lookup to use glob pattern expansion instead of checking individual paths. This ensures all chrony config files are properly discovered across different distributions that place configuration files in various subdirectories like /etc/chrony.d/ and /etc/chrony/conf.d/.
LiliDeng
reviewed
Nov 21, 2025
| sudo=True, | ||
| shell=True, | ||
| no_error_log=True, | ||
| ) |
Collaborator
There was a problem hiding this comment.
In current way, there are many outputs for not existing paths, make the output confusing.
You can use find tool to get all the .conf file.
Contributor
Author
There was a problem hiding this comment.
That is a great suggestion - I wasn't aware of the find tool. I will change the implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update chrony configuration file lookup to use glob pattern expansion instead of checking individual paths. This ensures all chrony config files are properly discovered across different distributions that place configuration files in various subdirectories like
/etc/chrony.d/and/etc/chrony/conf.d/.