Skip to content

Conversation

@conniey
Copy link
Member

@conniey conniey commented Nov 6, 2025

What does this PR do?

  • Adds a server.json to Azure.Mcp.Server
  • Adds a template server.json to Fabric.Mcp.Server
  • Updates build pipeline:
    • Update version information in server.json and publish as build_info
    • Publish the updated server.json to either staging or public based on publish target internal or public.

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copilot AI review requested due to automatic review settings November 6, 2025 23:40
@conniey conniey requested review from a team as code owners November 6, 2025 23:40
@github-project-automation github-project-automation bot moved this to Untriaged in Azure MCP Server Nov 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for publishing MCP server metadata to the official MCP repository registry. The changes introduce server.json files containing package metadata, update build scripts to use these files, and add deployment infrastructure.

  • Adds server.json files for Azure and Fabric MCP servers with registry metadata
  • Refactors packaging scripts to copy existing server.json files instead of generating them dynamically
  • Implements Deploy-ServerJson.ps1 script for publishing to the MCP registry
  • Updates version management to synchronize server.json versions with package versions

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
servers/Fabric.Mcp.Server/src/Fabric.Mcp.Server.csproj Adds ServerJsonPath and commented McpRepositoryName properties for Fabric server
servers/Fabric.Mcp.Server/server.json New server metadata file with placeholder values for description and package identifier
servers/Azure.Mcp.Server/src/Azure.Mcp.Server.csproj Adds ServerJsonPath and McpRepositoryName properties for Azure server
servers/Azure.Mcp.Server/server.json New server metadata file with complete Azure MCP server configuration for NuGet and npm packages
servers/Azure.Mcp.Server/README.md Adds MCPRepositoryMetadata insertion point for package processing
eng/scripts/Update-Version.ps1 Extends version update logic to synchronize versions in server.json files
eng/scripts/Pack-Nuget.ps1 Replaces dynamic server.json generation with file copy, adds MCPRepositoryMetadata to README processing
eng/scripts/Pack-Npm.ps1 Adds mcpName field to npm package.json from server properties
eng/scripts/Get-ProjectProperties.ps1 Adds ServerJsonPath and McpRepositoryName to list of extracted project properties
eng/scripts/Deploy-ServerJson.ps1 New script implementing MCP registry authentication and publication using Azure Key Vault and Go-based publisher tool
eng/pipelines/templates/jobs/update-mcp-repository.yml New pipeline job template for building MCP publisher and updating registry
eng/pipelines/templates/jobs/release.yml Integrates MCP repository update job into release pipeline

-TemporaryDirectory '$(Pipeline.TemporaryDirectory)'
-ReleaseType '${{ parameters.ReleaseType }}'
-KeyVaultName 'kv-azuresdk-codesign'
-KeyVaultKeyName ''
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The KeyVaultKeyName parameter is set to an empty string. This is required for the Azure Key Vault authentication in the Deploy-ServerJson.ps1 script and should be set to a valid key name.

Copilot uses AI. Check for mistakes.
@joshfree joshfree moved this from Untriaged to In Progress in Azure MCP Server Nov 7, 2025
@joshfree joshfree added the tools-McpRegistry MCP Server Registry / Repository / Marketplace label Nov 7, 2025
@joshfree joshfree added this to the 2025-11 milestone Nov 7, 2025
@joshfree
Copy link
Member

joshfree commented Nov 7, 2025

@joelverhagen PTAL too thanks

@weshaggard weshaggard requested a review from hallipr November 7, 2025 18:00
<PackageIcon>$(MSBuildThisFileDirectory)../azureicon.png</PackageIcon>

<!-- Official MCP repository settings -->
<McpRepositoryName>com.microsoft/azure-mcp</McpRepositoryName>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<McpRepositoryName>com.microsoft/azure-mcp</McpRepositoryName>
<McpRepositoryName>com.microsoft/azure</McpRepositoryName>

I would argue mcp is redundant in this context.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshfree I have no opinions. If the wider team is OK with this name... the shorter the better. :D

"$schema": "https://static.modelcontextprotocol.io/schemas/2025-10-17/server.schema.json",
"name": "com.microsoft/azure-mcp",
"description": "All Azure MCP tools to create a seamless connection between AI agents and Azure services.",
"version": "2.0.0-beta.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want icons? Probably yes, for parity with the existing.
It might be worth checking with Toby on how these icon URLs will be used for GitHub MCP Registry (direct linked, replicated, etc).

See modelcontextprotocol/registry#277 (comment) for issues...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could supply icon in a future release, if you want to move fast.

{
"registryType": "nuget",
"identifier": "Azure.Mcp",
"version": "2.0.0-beta.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it would be worth putting explicit placeholder values here? So is someone wonders "hmm ... this looks old" they will rest assured something else will fix it up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. We could have placeholder values

@conniey conniey force-pushed the conniey/server-json branch from 2613183 to 9cb4b8b Compare November 10, 2025 18:15
@hallipr
Copy link
Member

hallipr commented Nov 11, 2025

@chidozieononiwu, can you check the server.json content to make sure it's correct for npx packaging?

@hallipr
Copy link
Member

hallipr commented Nov 11, 2025

Can you update servers/Template.Mcp.Server as well? I'd like to be able to test this as part of Template's release pipeline

@conniey conniey force-pushed the conniey/server-json branch from 9036a2b to 48b9c51 Compare November 25, 2025 23:00
-BuildInfoPath '$(Pipeline.Workspace)/build_info/build_info.json'
-NpmRegistry '${{ parameters.NpmRegistry }}'
- template: /eng/pipelines/templates/jobs/update-mcp-repository.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we'll be publishing prerelease updates to the official registry pointing to internal/public package feeds?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration in this repo should have been called "Release Unofficial" or "Release Internal". It doesn't do the same jobs as Integration in the sdk repos

Copy link
Member Author

@conniey conniey Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh makes sense. I realise that staging.mcp. only performs the check against the official NuGet.org repo.. so it doesn't make sense since we don't host our own internal mcp repo. Let me remove this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nm. I see the staging repo work in Deploy-ServerJson.ps1

Write-Host "Installing Microsoft Go and building MCP publishing tool..."

# This go-install.ps1 script could be checked into your source repository
$goInstallScriptPath = "$PSScriptRoot/Install-Go.ps1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened an issue to see if all of this is really necessary. I suspect the publisher tool is just making an authenticated API call with either a token minted using our private key or with a body signed using our key. Either way, it could be all powershell with no git clone in the middle of a deployment step.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1256


<#
.SYNOPSIS
Verifies the NuGet package for the specified server is available on nuget.org.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance dotnet package search --exact-match would handle this for us reliably?

https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-package-search

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach was documented because it checks the same artifact (embedded package README) that the MCP Registry uses. dotnet package search --exact-match checks the NuGet.org package metadata endpoint. There is certainly a relationship between these two things (NuGet.org publishes README strictly before search availability) but for a general purpose script it helps avoid false positives when a package has forgotten to embed the README.

It is not a bad suggestion, I'm just providing the context.

<Description>Azure MCP Server - Model Context Protocol implementation for Azure</Description>
<ReadmeUrl>https://github.com/Microsoft/mcp/blob/main/servers/Azure.Mcp.Server#readme</ReadmeUrl>
<ReadmePath>$(RepoRoot)/servers/Azure.Mcp.Server/README.md</ReadmePath>
<ServerJsonPath>servers/Azure.Mcp.Server/server.json</ServerJsonPath>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paths should be absolute.

maybe

Suggested change
<ServerJsonPath>servers/Azure.Mcp.Server/server.json</ServerJsonPath>
<ServerJsonPath>$(RepoRoot)servers/Azure.Mcp.Server/server.json</ServerJsonPath>

or

Suggested change
<ServerJsonPath>servers/Azure.Mcp.Server/server.json</ServerJsonPath>
<ServerJsonPath>$(MSBuildThisFileDirectory)server.json</ServerJsonPath>

"title": "Azure MCP Server",
"packages": [
{
"registryType": "nuget",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this whole section be inject and not just the version. Otherwise, there's the possibility of conflict between the package name we see here and the one in the server's csproj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools-McpRegistry MCP Server Registry / Repository / Marketplace

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

7 participants