Using ARG query to support Aks resource read operations #424

ArthurMa1978 · 2025-09-12T08:50:39Z

What does this PR do?

This PR addresses part of the issue tracked in #226 by updating the SQL tool to eliminate its dependency on Azure.ResourceManager.ContainerService.
As a result, it reduces the MCP agent size by approximately 1.27 MB.

GitHub issue number?

#226

Pre-merge Checklist

Copilot

Pull Request Overview

This PR updates the AKS tool to eliminate its dependency on Azure.ResourceManager.ContainerService by migrating to Azure Resource Graph queries. This change reduces the MCP agent size by approximately 1.27 MB while maintaining the same functionality.

Replaced direct ARM API calls with Azure Resource Graph queries for better performance
Removed Azure.ResourceManager.ContainerService dependency to reduce package size
Added new model classes to handle JSON deserialization from Resource Graph responses

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
tools/Azure.Mcp.Tools.Aks/src/Azure.Mcp.Tools.Aks.csproj	Removed Azure.ResourceManager.ContainerService package dependency
tools/Azure.Mcp.Tools.Aks/src/Services/AksService.cs	Migrated from ARM API calls to Resource Graph queries using BaseAzureResourceService
tools/Azure.Mcp.Tools.Aks/src/Services/Models/*.cs	Added new model classes for JSON deserialization from Resource Graph results
tools/Azure.Mcp.Tools.Aks/src/Commands/*.cs	Updated error handling to support KeyNotFoundException from Resource Graph queries
core/Azure.Mcp.Core/src/Services/Azure/BaseAzureResourceService.cs	Made resourceGroup parameter nullable to support querying across all resource groups
servers/Azure.Mcp.Server/CHANGELOG.md	Documented the refactoring changes

tools/Azure.Mcp.Tools.Aks/src/Services/Models/AksPowerState.cs

tools/Azure.Mcp.Tools.Aks/src/Services/Models/AksNetworkProfile.cs

tools/Azure.Mcp.Tools.Aks/src/Services/Models/AksManagedClusterSku.cs

tools/Azure.Mcp.Tools.Aks/src/Services/Models/AksClusterProperties.cs

tools/Azure.Mcp.Tools.Aks/src/Services/Models/AksClusterData.cs

tools/Azure.Mcp.Tools.Aks/src/Services/Models/AksAgentPoolProperties.cs

tools/Azure.Mcp.Tools.Aks/src/Services/Models/AksAgentPoolProfile.cs

tools/Azure.Mcp.Tools.Aks/src/Services/Models/AksAgentPoolData.cs

ArthurMa1978 · 2025-09-12T11:00:37Z

eng/scripts/Check-Unused-ResourceProperties.ps1

@@ -1,297 +0,0 @@
-# PowerShell script to check for unused properties in Services/Models that are not used in Models mapping


Remove this script as it does not reliably detect unused resource properties in a generic manner.

ArthurMa1978 · 2025-09-12T11:01:31Z

tools/Azure.Mcp.Tools.Sql/src/Services/Models/SqlDatabaseProperties.cs

@@ -23,8 +23,6 @@ internal sealed class SqlDatabaseProperties
        public DateTimeOffset? CreatedOn { get; set; }
        /// <summary> The current service level objective name of the database. </summary>
        public string? CurrentServiceObjectiveName { get; set; }
-        /// <summary> The license type to apply for this database. `LicenseIncluded` if you need a license, or `BasePrice` if you have a license and are eligible for the Azure Hybrid Benefit. </summary>
-        public string? LicenseType { get; set; }


What do you mean by unused? It looks like an exported property, so not sure how you know it is unused by the caller.

The unused means not utilized by the MCP tool. I overlooked removing it in the previous PR when following up with your comment comment.

feiskyer · 2025-09-15T01:33:37Z

Is there any consistency issue by switching to ARG? Per my understanding, there may be latencies there and hence some data may not be quired back immediately after new operations and hence may introduce confusion/troubles for scenarios like troubleshooting.

/hold

ArthurMa1978 · 2025-09-16T00:11:20Z

Is there any consistency issue by switching to ARG? Per my understanding, there may be latencies there and hence some data may not be quired back immediately after new operations and hence may introduce confusion/troubles for scenarios like troubleshooting.

/hold

Hey @feiskyer, what I know the consistency issue has been resolved and is no longer a concern. Latency remains a known issue, but it's not specific to ARG, so I don't believe it's a blocker.

Fixed aks tests.

* Support starting server with multiple services * Remove comments * Fix and add test * Fix minor issues in doc and style * Reduce duplicated code * Fix spell error * Add a hint for starting server with multiple services * Simplify the format command in in doc * Use CommandLine library's Multiple Argument option to support passing multiple service values * Use finer level Exception type

feiskyer · 2025-09-17T00:21:00Z

Latency remains a known issue, but it's not specific to ARG, so I don't believe it's a blocker.

@ArthurMa1978 @joshfree Do we still want to implement something to detect the latency and refresh the data on such case? And does this change impact the write path (PUT/DELETE)? We're planning to add some create/write tools as well

ArthurMa1978 · 2025-09-17T01:32:46Z

Latency remains a known issue, but it's not specific to ARG, so I don't believe it's a blocker.

@ArthurMa1978 @joshfree Do we still want to implement something to detect the latency and refresh the data on such case? And does this change impact the write path (PUT/DELETE)? We're planning to add some create/write tools as well

The ARG provides sub-second query latency across subscriptions, though actual latency may vary depending on specific scenarios. This isn't an issue with ARG only, some mgmt. plane APIs may also not immediately reflect the latest data after changes are made. Therefore, I believe ARG is well-suited for any GET or LIST operations.
This update does not affect the write path. I'm currently working on a separate change to implement the write path using GenericResource, similar to this example: #456.

jongio · 2025-09-17T18:54:05Z

eng/scripts/Check-Unused-ResourceProperties.ps1

@hallipr ok to remove?

jongio · 2025-09-17T18:55:28Z

tools/Azure.Mcp.Tools.Sql/src/Services/Models/SqlDatabaseProperties.cs

@@ -23,8 +23,6 @@ internal sealed class SqlDatabaseProperties
        public DateTimeOffset? CreatedOn { get; set; }
        /// <summary> The current service level objective name of the database. </summary>
        public string? CurrentServiceObjectiveName { get; set; }
-        /// <summary> The license type to apply for this database. `LicenseIncluded` if you need a license, or `BasePrice` if you have a license and are eligible for the Azure Hybrid Benefit. </summary>
-        public string? LicenseType { get; set; }


What do you mean by unused? It looks like an exported property, so not sure how you know it is unused by the caller.

feiskyer · 2025-09-19T01:24:49Z

The ARG provides sub-second query latency across subscriptions, though actual latency may vary depending on specific scenarios.

This is a real issue that may cause AI Agent to perform wrong actions. If ARG is not required, I'd prefer we still keep the current logic to ensure data correctness.

ArthurMa1978 added 4 commits September 12, 2025 15:36

Using ARG query to support Aks resource read operations

fbff867

Merge branch 'main' into mgmt-aks

b198da7

Merge branch 'main' into mgmt-aks

25b8d7e

Update

723101b

ArthurMa1978 requested a review from feiskyer as a code owner September 12, 2025 08:50

Copilot AI review requested due to automatic review settings September 12, 2025 08:50

ArthurMa1978 requested review from a team as code owners September 12, 2025 08:50

ArthurMa1978 requested a review from jongio September 12, 2025 08:50

github-project-automation bot added this to Azure MCP Server Sep 12, 2025

ArthurMa1978 requested review from vukelich, conniey, xiangyan99, JonathanCrd, msalaman and JasonYeMSFT September 12, 2025 08:50

github-project-automation bot moved this to Untriaged in Azure MCP Server Sep 12, 2025

Update changelog

273eb56

Copilot AI reviewed Sep 12, 2025

View reviewed changes

ArthurMa1978 added 2 commits September 12, 2025 18:53

update

3d560cc

update

d7e6dd3

ArthurMa1978 commented Sep 12, 2025

View reviewed changes

fixed format errors

7efa66a

Normalized cspell settings.

9c1857b

Fixed aks tests.

ArthurMa1978 requested review from ericshape, jeremyfrosti and mitesh-pv as code owners September 16, 2025 00:42

ArthurMa1978 requested review from achyuth-ms and gossion as code owners September 16, 2025 00:42

update

5f10fe2

joshfree moved this from Untriaged to In Progress in Azure MCP Server Sep 16, 2025

Merge branch 'main' into mgmt-aks

bc8476c

jongio reviewed Sep 17, 2025

View reviewed changes

joshfree added the Azure.Mcp.Server label Sep 17, 2025

joshfree assigned ArthurMa1978 Sep 17, 2025

ArthurMa1978 added 2 commits September 18, 2025 18:15

Merge branch 'main' into mgmt-aks

945304a

Merge branch 'main' into mgmt-aks

cd47106

		@@ -1,297 +0,0 @@
		# PowerShell script to check for unused properties in Services/Models that are not used in Models mapping

Using ARG query to support Aks resource read operations #424

Are you sure you want to change the base?

Using ARG query to support Aks resource read operations #424

Uh oh!

Conversation

ArthurMa1978 commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

GitHub issue number?

Pre-merge Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ArthurMa1978 Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

ArthurMa1978 Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

jongio Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

ArthurMa1978 Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

feiskyer commented Sep 15, 2025

Uh oh!

ArthurMa1978 commented Sep 16, 2025

Uh oh!

feiskyer commented Sep 17, 2025

Uh oh!

ArthurMa1978 commented Sep 17, 2025

Uh oh!

jongio Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

jongio Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

feiskyer commented Sep 19, 2025

Uh oh!

Uh oh!

ArthurMa1978 commented Sep 12, 2025 •

edited

Loading