Skip to content

Conversation

hallipr
Copy link
Member

@hallipr hallipr commented Sep 16, 2025

What does this PR do?

Removes the complexity of using an output variable for the version suffix by creating a global variable.
Replaces $(PipelineArtifactName) based artifact names with consistent static names:

  • build_{platform}
  • binaries_signed
  • packages_npm
  • packages_vsix_signed
  • packages_nuget_signed
  • docker_staged

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Updated command list in /docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@Copilot Copilot AI review requested due to automatic review settings September 16, 2025 18:43
@hallipr hallipr requested review from a team as code owners September 16, 2025 18:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the pipeline configuration by removing dynamic version suffix generation and standardizing artifact naming conventions. The changes move version suffix logic from a job output variable to a global variable and replace dynamic artifact names with consistent static names.

  • Moves version suffix logic from Initialize job output to global variable in globals.yml
  • Standardizes artifact names to consistent static patterns (build_, binaries_signed, packages_*)
  • Removes dependencies on the Initialize stage and simplifies parameter handling

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
eng/pipelines/templates/variables/globals.yml Adds global VersionSuffix variable logic and removes PipelineArtifactName
eng/pipelines/templates/common.yml Removes Initialize stage dependencies and VersionSuffix variable references
eng/pipelines/templates/jobs/initialize.yml Removes dynamic version suffix generation logic
eng/pipelines/templates/jobs/build.yml Updates artifact name to use static build_ prefix
eng/pipelines/templates/jobs/sign-and-pack.yml Updates artifact references to use static names
eng/pipelines/templates/jobs/npm/pack-npm.yml Updates artifact names from dynamic to static packages_npm
eng/pipelines/templates/jobs/nuget/pack-and-sign-nuget.yml Updates artifact names to packages_nuget_signed
eng/pipelines/templates/jobs/vsix/pack-and-sign-vsix.yml Updates artifact names to packages_vsix_signed and binaries_signed
eng/pipelines/templates/jobs/integration.yml Updates artifact references to use static names
eng/pipelines/templates/jobs/release.yml Updates artifact references and removes VsixTargets parameter
eng/pipelines/templates/jobs/docker/release-docker.yml Updates artifact name to binaries_signed
Comments suppressed due to low confidence (1)

eng/pipelines/templates/variables/globals.yml:1

  • The removed PipelineArtifactName variable is being replaced with static names throughout the codebase. Ensure all references to this variable have been updated to prevent build failures.
variables:

@joshfree joshfree moved this from Untriaged to In Progress in Azure MCP Server Sep 16, 2025
@hallipr hallipr enabled auto-merge (squash) September 18, 2025 18:41
@hallipr hallipr merged commit 0d4f5b2 into microsoft:main Sep 19, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants