-
Notifications
You must be signed in to change notification settings - Fork 184
Use static artifact names and version suffix veriable #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR simplifies the pipeline configuration by removing dynamic version suffix generation and standardizing artifact naming conventions. The changes move version suffix logic from a job output variable to a global variable and replace dynamic artifact names with consistent static names.
- Moves version suffix logic from Initialize job output to global variable in globals.yml
- Standardizes artifact names to consistent static patterns (build_, binaries_signed, packages_*)
- Removes dependencies on the Initialize stage and simplifies parameter handling
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
eng/pipelines/templates/variables/globals.yml | Adds global VersionSuffix variable logic and removes PipelineArtifactName |
eng/pipelines/templates/common.yml | Removes Initialize stage dependencies and VersionSuffix variable references |
eng/pipelines/templates/jobs/initialize.yml | Removes dynamic version suffix generation logic |
eng/pipelines/templates/jobs/build.yml | Updates artifact name to use static build_ prefix |
eng/pipelines/templates/jobs/sign-and-pack.yml | Updates artifact references to use static names |
eng/pipelines/templates/jobs/npm/pack-npm.yml | Updates artifact names from dynamic to static packages_npm |
eng/pipelines/templates/jobs/nuget/pack-and-sign-nuget.yml | Updates artifact names to packages_nuget_signed |
eng/pipelines/templates/jobs/vsix/pack-and-sign-vsix.yml | Updates artifact names to packages_vsix_signed and binaries_signed |
eng/pipelines/templates/jobs/integration.yml | Updates artifact references to use static names |
eng/pipelines/templates/jobs/release.yml | Updates artifact references and removes VsixTargets parameter |
eng/pipelines/templates/jobs/docker/release-docker.yml | Updates artifact name to binaries_signed |
Comments suppressed due to low confidence (1)
eng/pipelines/templates/variables/globals.yml:1
- The removed PipelineArtifactName variable is being replaced with static names throughout the codebase. Ensure all references to this variable have been updated to prevent build failures.
variables:
What does this PR do?
Removes the complexity of using an output variable for the version suffix by creating a global variable.
Replaces $(PipelineArtifactName) based artifact names with consistent static names:
GitHub issue number?
[Link to the GitHub issue this PR addresses]
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.md
and/orservers/Fabric.Mcp.Server/CHANGELOG.md
for product changes (features, bug fixes, UI/UX, updated dependencies
)servers/Azure.Mcp.Server/README.md
and/orservers/Fabric.Mcp.Server/README.md
documentation/docs/azmcp-commands.md
and/or/docs/fabric-commands.md
ToolDescriptionEvaluator
and obtained a score of0.4
or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.md
crypto mining, spam, data exfiltration, etc.
)/azp run mcp - pullrequest - live
to run Live Test Pipeline