Skip to content

Conversation

conniey
Copy link
Member

@conniey conniey commented Sep 17, 2025

What does this PR do?

  • Changes IAreaSetup to register Commands in ConfigureServices and use IServiceProvider to resolve commands.
    • At the moment, Commands only inject ILogger<T> in their constructor, which makes testing harder.
  • Changes CommandFactory.GetServiceArea to check for service area with and without using root prefix for a match.
    • In cases where the MCP tool was created in namespace mode, the tool's name is not prefixed with azmcp.

GitHub issue number?

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Updated command list in /docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@conniey conniey force-pushed the register-area-update branch from 7282493 to 31a2f52 Compare September 22, 2025 21:38
@conniey conniey force-pushed the register-area-update branch from 31a2f52 to edc4dfc Compare September 23, 2025 11:15
@conniey conniey enabled auto-merge (squash) September 23, 2025 17:21
@conniey conniey disabled auto-merge September 23, 2025 17:21
@conniey
Copy link
Member Author

conniey commented Sep 23, 2025

/check-enforcer override

@conniey conniey merged commit 13e0baf into microsoft:main Sep 23, 2025
49 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server Sep 23, 2025
@conniey conniey deleted the register-area-update branch September 23, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server-Azure.Mcp Azure.Mcp.Server
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants