Support character-limit in list_sub tool #483
Open
+257
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangyan99
requested review from
wbreza,
Copilot,
KarishmaGhiya,
conniey,
tmeschter,
JonathanCrd,
msalaman and
JasonYeMSFT
There was a problem hiding this comment.
Pull Request Overview
This PR adds character-limit support to the Azure MCP Server's subscription list tool, allowing users to control response size through a new --character-limit parameter with a default limit of 10,000 characters. When the response exceeds the limit, subscriptions are automatically truncated with informative status messages.
Key changes:
- Added
--character-limitparameter to control response size with automatic truncation - Enhanced response messages to include character count and truncation status
- Added comprehensive test coverage for various character limit scenarios
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
CHANGELOG.md |
Documents the new character-limit parameter feature |
SubscriptionListCommandTests.cs |
Adds extensive test coverage for character limit functionality |
OptionDefinitions.cs |
Defines the new CharacterLimit option with 10,000 character default |
SubscriptionListOptions.cs |
Adds CharacterLimit property to subscription list options |
SubscriptionListCommand.cs |
Implements character limit logic with response truncation |
core/Azure.Mcp.Core/src/Areas/Subscription/Commands/SubscriptionListCommand.cs
Show resolved
Hide resolved
core/Azure.Mcp.Core/src/Areas/Subscription/Commands/SubscriptionListCommand.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a clear, concise description of the changes]Support character-limit in list_sub tool
#428
[Any additional context, screenshots, or information that helps reviewers]GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentation/docs/azmcp-commands.mdand/or/docs/fabric-commands.mdToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline